-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline search for solution process #18500
base: main
Are you sure you want to change the base?
Conversation
There are a few things that aren't handled yet like linking the KB article in addition to just copying the content, pagination, etc. This work is going to need be more complex so I put it to draft. |
It should be good like this. |
0695299
to
f882458
Compare
@orthagh Is this PR OK for you ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost
There is UI polishing to do:
-
KB articles with HTML elements (images, bold, titles, etc) appear raw. At least, I expect to have the new lines respected, if you prefer to display only text.
-
Maybe we can truncate (rather overflow hidden) articles in the list searching for a solution and avoid them being higher than 100-150px
-
mini button "Use as solution" and "preview" should have tooltips.
-
avoid double border
-
The preview mode of an article has some quirks
- can avoid double border also here
- We miss a "Use as solution" button
The truncation is based on |
I'm not sure, we can just set a fixed limit for this feature. I don't see any advantage to let the user change the height here. |
f882458
to
3fc35ad
Compare
UI/UX review:
|
Checklist before requesting a review
Description
When using object locks, there was an opportunity for a technician to lose the lock on a ticket when searching for a solution because the process redirects out of the ticket for the solution search/selection part.
This PR moves the solution selection to a modal and allows adding the article content directly to the solution content without any redirects/page reloads.
Fixes #18490