Extract manuallink form to a controller

[Pierstoval]

No description provided.

[trasher]

Seems good but I do not know how to test it, I cannot reach front/manualink.form.php on current master (maybe a permission issue, ,no idea).

[cconard96]

Seems good but I do not know how to test it, I cannot reach front/manualink.form.php on current master (maybe a permission issue, ,no idea).

The itemtype and items_id params are required in the URL currently. The form probably should have been inline with the link list for the asset instead of a separate page.

[Pierstoval]

The form probably should have been inline with the link list for the asset instead of a separate page.

Separate pages seem to be used for all instances of CommonDBChild, I guess the reason is that most forms are loaded via AJAX and it's easier this way.

[cconard96]

The form probably should have been inline with the link list for the asset instead of a separate page.

Separate pages seem to be used for all instances of CommonDBChild, I guess the reason is that most forms are loaded via AJAX and it's easier this way.

Some things like rule actions and criteria are embedded via a viewsubitem.php AJAX call. Their .form.php files only exist to handle add/update/delete but not show. One of my recent PRs even adds a Twig template for viewsubitem that optionally submits the form over AJAX to avoid page reloads.

[Pierstoval]

@cconard96 what would you recommend then?

[cconard96]

My suggestion since it is a very small form is to display it inside the Link tab for assets.

When the tab loads, the display remains as it is now with the 2 buttons and then a list of links under them.
When clicking the "Add" button, the button disappears the manual link form is displayed using the viewsubitem template.
When clicking a row in the list that corresponds to a manual link, the viewsubitem form is shows with the data for that link.
When clicking a row for a regular link, it redirects to the Link form.

I'm not saying it has to be done here and I can make this change myself in another PR if other people agree with this UX.