Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make .deb mostly lintian clean #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make .deb mostly lintian clean #1

wants to merge 1 commit into from

Conversation

cbayle
Copy link

@cbayle cbayle commented Sep 11, 2016

also :

  • make it work with last glpi version
  • don't download what was already downloaded
  • add alternate dependencies to build and run on ubuntu xenial

todo :

  • more testing
  • fix some permissions in /var
  • test it still works on debian
  • looks like Zend is embedded and should use distro provided one
  • jquery-gantt, jquery-ui-scrollable-tabs should probably be packaged separatly

@orthagh
Copy link
Contributor

orthagh commented Sep 13, 2016

Hello @cbayle.

Thank you for this pr.
I have some inline comments. Incoming.

orthagh
orthagh reviewed Sep 13, 2016
View reviewed changes
templates/rules
rm -rf $(DESTDIR)/usr/share/glpi/lib/jqueryplugins/jquery-ui-timepicker-addon
# fix various lintian
# existing package / font
rm -f $(DESTDIR)/usr/share/glpi/lib/jqueryplugins/jquery-ui-scrollable-tabs/js/jquery.mousewheel.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i didn't miss it, i don't see this lib in control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbayle @orthagh @cbayleOL