Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code. #1713

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Remove unused code. #1713

merged 2 commits into from
Feb 5, 2024

Conversation

joaander
Copy link
Member

@joaander joaander commented Feb 1, 2024 •
edited
Loading

Description

Remove unused _children methods.

Motivation and context

There is no need to keep unused code.

How has this been tested?

Unit tests pass.

Change log

Changed:

* Removed unused ``Operation._children`` methods
  (`#1713 <https://github.com/glotzerlab/hoomd-blue/pull/1713>`__).

Checklist:

@joaander joaander added the validate Execute long running validation tests on pull requests label Feb 1, 2024
@joaander joaander marked this pull request as ready for review February 1, 2024 19:32
@joaander joaander requested review from a team, tcmoore3, SchoeniPhlippsn and Tobias-Dwyer and removed request for a team February 1, 2024 19:32
@joaander joaander merged commit d3cf2f9 into trunk-minor Feb 5, 2024
40 checks passed
@joaander joaander deleted the remove-unused-code branch February 5, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbridley janbridley janbridley approved these changes

@tcmoore3 tcmoore3 Awaiting requested review from tcmoore3

@SchoeniPhlippsn SchoeniPhlippsn Awaiting requested review from SchoeniPhlippsn

@Tobias-Dwyer Tobias-Dwyer Awaiting requested review from Tobias-Dwyer

Assignees
No one assigned
Labels
validate Execute long running validation tests on pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaander @janbridley