Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messages: Fix for production using Globalize runtime #33

Closed
wants to merge 1 commit into from
Closed

Messages: Fix for production using Globalize runtime #33

wants to merge 1 commit into from

Conversation

rxaviers
Copy link
Member

@rxaviers rxaviers commented Dec 3, 2015

Fixes #32

@rxaviers
Copy link
Member Author

rxaviers commented Dec 3, 2015

@alunny, the above fix works for me. It would be great if you could test it in your projects too before we land.

PS: We really need to get #1 addressed. 🙈

@rxaviers
Copy link
Member Author

rxaviers commented Dec 7, 2015

@alunny and @kborchers if there's no objection, I plan to land this and create a new patch release.

@kborchers
Copy link
Collaborator

I don't have a project to test in but reading it lgtm 👍

@kborchers
Copy link
Collaborator

Also agree on needing tests. If I can find any free time (lol) I would love to look into Intern or QUnit + https://github.com/airbnb/enzyme

@rxaviers rxaviers closed this in 15034ae Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rxaviers @kborchers