Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: duplicates in portalicious #6522

Draft
wants to merge 2 commits into
base: feat.duplicates
Choose a base branch
from

Conversation

aberonni
Copy link
Contributor

@aberonni aberonni commented Feb 14, 2025

AB#33536 AB#33535

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

https://lively-river-04adce503-6522.westeurope.5.azurestaticapps.net

@aberonni aberonni added the enhancement New feature or request that affects our end users label Feb 14, 2025
@aberonni aberonni changed the base branch from main to feat.duplicates February 18, 2025 08:38
@aberonni aberonni changed the title feat: duplicate registrations banner feat: duplicates in portalicious Feb 18, 2025
@aberonni aberonni force-pushed the aberonni/duplicate-registrations-banner branch from e178753 to 48a5ec9 Compare February 18, 2025 08:40
@aberonni aberonni force-pushed the aberonni/duplicate-registrations-banner branch from 48a5ec9 to 160241e Compare February 18, 2025 11:26
@aberonni aberonni force-pushed the aberonni/duplicate-registrations-banner branch from 160241e to 900ebd3 Compare February 18, 2025 11:46
@aberonni aberonni force-pushed the aberonni/duplicate-registrations-banner branch from 900ebd3 to d856af3 Compare February 18, 2025 11:51
aberonni added a commit that referenced this pull request Feb 18, 2025
AB#33731

This makes sure that we invalidate cache for registration queries that rely on referenceId, as well as the queries that rely on registration.id

This was causing issues because the new "getDuplicates" endpoint (implemented in #6522) uses referenceId, and the cache for it was not being invalidated after editing personal information.
aberonni added a commit that referenced this pull request Feb 18, 2025
AB#33731

This makes sure that we invalidate cache for registration queries that rely on referenceId, as well as the queries that rely on registration.id

This was causing issues because the new "getDuplicates" endpoint (implemented in #6522) uses referenceId, and the cache for it was not being invalidated after editing personal information.
@aberonni aberonni force-pushed the aberonni/duplicate-registrations-banner branch from d856af3 to 95d0d7a Compare February 18, 2025 13:50
@aberonni aberonni force-pushed the aberonni/duplicate-registrations-banner branch from 95d0d7a to 68a74f9 Compare February 18, 2025 14:15
@aberonni aberonni force-pushed the aberonni/duplicate-registrations-banner branch from 68a74f9 to 1ccb23e Compare February 19, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request that affects our end users
Development

Successfully merging this pull request may close these issues.

1 participant