Intersolve visa physical card data endpoint change (Merge after 26 of February) #6498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
services/121-service/src/payments/fsp-integration/intersolve-visa/intersolve-visa.api.service.ts:214
- Ensure that the new endpoint
physical-card-statusis covered by tests.
endpoint: `tokens/${tokenCode}/physical-card-status`,
|
Do not merge, we are waiting on confirmation from intersolve that this change is also on their production server Edit: This change will be released by intersolve 26 of February so this can be merged after that |
diderikvw
force-pushed
the
chore.visa-physical-card-api
branch
from
7c88881 to
35529f4
Compare
diderikvw
requested changes
Feb 10, 2025
services/mock-service/src/fsp-integration/intersolve-visa/intersolve-visa.mock.controller.ts
Outdated
Show resolved
Hide resolved
RubenGeo
changed the title
RubenGeo
changed the title
diderikvw
approved these changes
Feb 11, 2025
…rsolve-visa.mock.controller.ts Co-authored-by: diderikvw <[email protected]>
diderikvw
force-pushed
the
chore.visa-physical-card-api
branch
from
ca2fe0a to
fd3ed65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#33427
I tested this locally against the mock service of intersolve and it seemed to work fine
Describe your changes
Checklist before requesting a review
Portalicious preview deployment
This PR does not have any preview deployments yet.