fix capture render tree fails when errors in args #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricklx
commented
Oct 24, 2023
| @@ -21,7 +21,7 @@ export default function generateVmPlugins( | |||
| return [ | |||
| [ | |||
| __loadPlugins | |||
| ? | |||
There was a problem hiding this comment.
auto save...
well lets cleanup this space
| @@ -181,7 +181,7 @@ export default class DebugRenderTreeImpl<TBucket extends object> | |||
| let template = this.captureTemplate(node); | |||
| let bounds = this.captureBounds(node); | |||
| let children = this.captureRefs(refs); | |||
| return { id, type, name, args: reifyArgs(args), instance, template, bounds, children }; | |||
| return { id, type, name, args: reifyArgsDebug(args), instance, template, bounds, children }; | |||
There was a problem hiding this comment.
Does this always happen? Do we want this to occur un production or dev only?
There was a problem hiding this comment.
i think its should be for both
| @@ -58,5 +58,6 @@ export interface CapturedNamedArguments extends Record<string, Reference> { | |||
|
|
|||
| export interface Arguments { | |||
| positional: readonly unknown[]; | |||
| errors: Record<string, Error>; | |||
There was a problem hiding this comment.
Where all is this interface used? If it's public, i'm worried about adding to it.
If it's internal, then it's fine
There was a problem hiding this comment.
it would be used for the inspector, to distinguish if an arg throws an error, or if it return an Error.
as it could also just be a return new Error()
|
@NullVoxPopuli shall we try this again? |
NullVoxPopuli
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
better alternative to #1447 .
i''m actually not sure anymore how meta.discource. was in a state where it could render the components, but would fail when using inspector.
having errors in the args would cause rendering to fail as well.