Skip to content

Commit

Permalink
Run lint:fix
Browse files Browse the repository at this point in the history
  • Loading branch information
@NullVoxPopuli
NullVoxPopuli committed Jan 23, 2025
1 parent 97217c9 commit 921cda6
Show file tree
Hide file tree
Showing 39 changed files with 176 additions and 158 deletions.
2 changes: 1 addition & 1 deletion .vscode/extensions.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@
"esbenp.prettier-vscode",
"dnut.rewrap-revived"
]
}
}
27 changes: 7 additions & 20 deletions .vscode/settings.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@
},
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.formatOnSave": false,
"editor.rulers": [
100
]
"editor.rulers": [100]
},
"[json][jsonc][markdown][yaml]": {
"editor.codeActionsOnSave": {
Expand All @@ -33,7 +31,7 @@
{
"color": "#aaaaaa66",
"column": 80
},
}
],
"eslint.codeAction.showDocumentation": {
"enable": true
Expand All @@ -48,12 +46,7 @@
"eslint.problems.shortenToSingleLine": true,
"eslint.runtime": "node",
"eslint.useFlatConfig": true,
"eslint.validate": [
"javascript",
"typescript",
"json",
"jsonc"
],
"eslint.validate": ["javascript", "typescript", "json", "jsonc"],
"eslint.workingDirectories": [
{
"pattern": "."
Expand Down Expand Up @@ -126,15 +119,9 @@
}
},
"inline-bookmarks.expert.custom.words.mapping": {
"audit": [
"@audit(\\s|$)"
],
"fixme": [
"@fixme(\\s|$)"
],
"warn": [
"@premerge(\\s|$)"
],
"audit": ["@audit(\\s|$)"],
"fixme": ["@fixme(\\s|$)"],
"warn": ["@premerge(\\s|$)"],
"bandaid": [
"@bandaid\\(until:[^)]+\\)(\\s|$)",
"@bandaid(?=\\{@link [^}]+\\}(\\s|$))",
Expand All @@ -161,4 +148,4 @@
"typescript.tsdk": "node_modules/typescript/lib",
"typescript.updateImportsOnFileMove.enabled": "always",
"typescript.reportStyleChecksAsWarnings": false
}
}
1 change: 0 additions & 1 deletion bin/update-package-json.mts
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

import { existsSync, readFileSync, writeFileSync } from 'node:fs';
import { resolve } from 'node:path';

Expand Down
94 changes: 47 additions & 47 deletions glimmer-vm.code-workspace
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,184 +2,184 @@
"folders": [
{
"name": "✨ glimmer-engine",
"path": "."
"path": ".",
},
{
"name": "glimmer-benchmark",
"path": "benchmark"
"path": "benchmark",
},
{
"name": "@glimmer-workspace/krausest",
"path": "benchmark/benchmarks/krausest"
"path": "benchmark/benchmarks/krausest",
},
{
"name": "@glimmer-workspace/bin",
"path": "bin"
"path": "bin",
},
{
"name": "📦 packages",
"path": "packages"
"path": "packages",
},
{
"name": "📦 @glimmer-workspace/benchmark-env",
"path": "packages/@glimmer-workspace/benchmark-env"
"path": "packages/@glimmer-workspace/benchmark-env",
},
{
"name": "📦 @glimmer-workspace/build-support",
"path": "packages/@glimmer-workspace/build"
"path": "packages/@glimmer-workspace/build",
},
{
"name": "📦 @glimmer-workspace/eslint-plugin",
"path": "packages/@glimmer-workspace/eslint-plugin"
"path": "packages/@glimmer-workspace/eslint-plugin",
},
{
"name": "📦 @glimmer-workspace/integration-tests",
"path": "packages/@glimmer-workspace/integration-tests"
"path": "packages/@glimmer-workspace/integration-tests",
},
{
"name": "📦 @glimmer-workspace/test-utils",
"path": "packages/@glimmer-workspace/test-utils"
"path": "packages/@glimmer-workspace/test-utils",
},
{
"name": "📦 @glimmer/compiler",
"path": "packages/@glimmer/compiler"
"path": "packages/@glimmer/compiler",
},
{
"name": "📦 @glimmer-test/compiler",
"path": "packages/@glimmer/compiler/test"
"path": "packages/@glimmer/compiler/test",
},
{
"name": "📦 @glimmer/debug",
"path": "packages/@glimmer/debug"
"path": "packages/@glimmer/debug",
},
{
"name": "📦 @glimmer/destroyable",
"path": "packages/@glimmer/destroyable"
"path": "packages/@glimmer/destroyable",
},
{
"name": "📦 @glimmer-test/destroyable",
"path": "packages/@glimmer/destroyable/test"
"path": "packages/@glimmer/destroyable/test",
},
{
"name": "📦 @glimmer/dom-change-list",
"path": "packages/@glimmer/dom-change-list"
"path": "packages/@glimmer/dom-change-list",
},
{
"name": "📦 @glimmer-test/dom-change-list",
"path": "packages/@glimmer/dom-change-list/test"
"path": "packages/@glimmer/dom-change-list/test",
},
{
"name": "📦 @glimmer/encoder",
"path": "packages/@glimmer/encoder"
"path": "packages/@glimmer/encoder",
},
{
"name": "📦 @glimmer/global-context",
"path": "packages/@glimmer/global-context"
"path": "packages/@glimmer/global-context",
},
{
"name": "📦 @glimmer/interfaces",
"path": "packages/@glimmer/interfaces"
"path": "packages/@glimmer/interfaces",
},
{
"name": "📦 @glimmer/local-debug-flags",
"path": "packages/@glimmer/local-debug-flags"
"path": "packages/@glimmer/local-debug-flags",
},
{
"name": "📦 @glimmer/manager",
"path": "packages/@glimmer/manager"
"path": "packages/@glimmer/manager",
},
{
"name": "📦 @glimmer-test/manager",
"path": "packages/@glimmer/manager/test"
"path": "packages/@glimmer/manager/test",
},
{
"name": "📦 @glimmer/node",
"path": "packages/@glimmer/node"
"path": "packages/@glimmer/node",
},
{
"name": "📦 @glimmer/opcode-compiler",
"path": "packages/@glimmer/opcode-compiler"
"path": "packages/@glimmer/opcode-compiler",
},
{
"name": "📦 @glimmer/owner",
"path": "packages/@glimmer/owner"
"path": "packages/@glimmer/owner",
},
{
"name": "📦 @glimmer-test/owner",
"path": "packages/@glimmer/owner/test"
"path": "packages/@glimmer/owner/test",
},
{
"name": "📦 @glimmer/program",
"path": "packages/@glimmer/program"
"path": "packages/@glimmer/program",
},
{
"name": "📦 @glimmer-test/program",
"path": "packages/@glimmer/program/test"
"path": "packages/@glimmer/program/test",
},
{
"name": "📦 @glimmer/reference",
"path": "packages/@glimmer/reference"
"path": "packages/@glimmer/reference",
},
{
"name": "📦 @glimmer-test/reference",
"path": "packages/@glimmer/reference/test"
"path": "packages/@glimmer/reference/test",
},
{
"name": "📦 @glimmer/runtime",
"path": "packages/@glimmer/runtime"
"path": "packages/@glimmer/runtime",
},
{
"name": "📦 @glimmer/syntax",
"path": "packages/@glimmer/syntax"
"path": "packages/@glimmer/syntax",
},
{
"name": "📦 @glimmer-test/syntax",
"path": "packages/@glimmer/syntax/test"
"path": "packages/@glimmer/syntax/test",
},
{
"name": "📦 @glimmer/util",
"path": "packages/@glimmer/util"
"path": "packages/@glimmer/util",
},
{
"name": "📦 @glimmer-test/util",
"path": "packages/@glimmer/util/test"
"path": "packages/@glimmer/util/test",
},
{
"name": "📦 @glimmer/validator",
"path": "packages/@glimmer/validator"
"path": "packages/@glimmer/validator",
},
{
"name": "📦 @glimmer-test/validator",
"path": "packages/@glimmer/validator/test"
"path": "packages/@glimmer/validator/test",
},
{
"name": "📦 @glimmer/vm",
"path": "packages/@glimmer/vm"
"path": "packages/@glimmer/vm",
},
{
"name": "📦 @glimmer/vm-babel-plugins",
"path": "packages/@glimmer/vm-babel-plugins"
"path": "packages/@glimmer/vm-babel-plugins",
},
{
"name": "📦 @glimmer/wire-format",
"path": "packages/@glimmer/wire-format"
"path": "packages/@glimmer/wire-format",
},
{
"name": "📦 @types/js-reporters",
"path": "packages/@types/js-reporters"
"path": "packages/@types/js-reporters",
},
{
"name": "📦 @types/puppeteer-chromium-resolver",
"path": "packages/@types/puppeteer-chromium-resolver"
"path": "packages/@types/puppeteer-chromium-resolver",
},
{
"name": "📦 @types/qunit",
"path": "packages/@types/qunit"
}
"path": "packages/@types/qunit",
},
],
"settings": {
"typescript.tsc.autoDetect": "on",
"typescript.tsdk": "node_modules/typescript/lib",
"typescript.tsserver.experimental.enableProjectDiagnostics": true
}
"typescript.tsserver.experimental.enableProjectDiagnostics": true,
},
}
2 changes: 0 additions & 2 deletions guides/workspace/vscode.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ See [Standard Annotations](./workspace-management.md#standard-annotations) in `w

<kbd> ![fixme](./demos/fixme.png) </kbd>



### NPM Dependency Links (`herrmannplatz.npm-dependency-links`)

This extension will turn your dependencies and devDependencies in your `package.json` into links to
Expand Down
12 changes: 6 additions & 6 deletions packages/@glimmer-workspace/integration-tests/lib/components/emberish-curly.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,15 @@ export class EmberishCurlyComponent {
public static positionalParams: string[] | string = [];

public dirtinessTag: DirtyableTag = createTag();
public declare layout: Template;
public declare name: string;
declare public layout: Template;
declare public name: string;
public tagName: Nullable<string> = null;
public attributeBindings: Nullable<string[]> = null;
public declare attrs: Attrs;
public declare element: Element;
public declare bounds: Bounds;
declare public attrs: Attrs;
declare public element: Element;
declare public bounds: Bounds;
public parentView: Nullable<EmberishCurlyComponent> = null;
public declare args: CapturedNamedArguments;
declare public args: CapturedNamedArguments;

public _guid: string;

Expand Down
2 changes: 1 addition & 1 deletion packages/@glimmer-workspace/integration-tests/lib/modes/rehydration/delegate.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export class RehydrationDelegate implements RenderDelegate {
public clientDoc: SimpleDocument;
public serverDoc: SimpleDocument;

public declare rehydrationStats: RehydrationStats;
declare public rehydrationStats: RehydrationStats;

private self: Nullable<Reference> = null;

Expand Down
6 changes: 1 addition & 5 deletions ...glimmer-workspace/integration-tests/lib/modes/rehydration/partial-rehydration-delegate.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,7 @@ export class PartialRehydrationDelegate extends RehydrationDelegate {
this.registerComponent('TemplateOnly', 'TemplateOnly', name, layout);
}

renderComponentClientSide(
name: string,
args: Dict,
element: SimpleElement
): RenderResult {
renderComponentClientSide(name: string, args: Dict, element: SimpleElement): RenderResult {
let cursor = { element, nextSibling: null };
let context = this.clientContext;
let tree = this.getElementBuilder(context.env, cursor) as DebugRehydrateTree;
Expand Down
1 change: 0 additions & 1 deletion packages/@glimmer-workspace/integration-tests/lib/snapshot.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ export function normalizeSnapshot(
const normalizedOld: IndividualSnapshot[] = [];
const normalizedNew: IndividualSnapshot[] = [];


while (true) {
const nextOld = oldIterator.peek();
const nextNew = newIterator.peek();
Expand Down
12 changes: 8 additions & 4 deletions packages/@glimmer-workspace/integration-tests/test/compiler/compile-options-test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -214,17 +214,21 @@ module('[glimmer-compiler] precompile', ({ test }) => {
test('when "this" in in locals, it compiles to GetLexicalSymbol', (assert) => {
let target = { message: 'hello' };
let _wire: ReturnType<typeof compile>;
(function() {
(function () {
_wire = compile(`{{this.message}}`, ['this'], (source) => eval(source));
}).call(target)
}).call(target);
let wire = _wire!;
assert.deepEqual(wire.scope?.(), [target]);
assert.deepEqual(wire.block[0], [[SexpOpcodes.Append,[SexpOpcodes.GetLexicalSymbol,0,["message"]]]])
assert.deepEqual(wire.block[0], [
[SexpOpcodes.Append, [SexpOpcodes.GetLexicalSymbol, 0, ['message']]],
]);
});

test('when "this" is not in locals, it compiles to GetSymbol', (assert) => {
let wire = compile(`{{this.message}}`, [], (source) => eval(source));
assert.strictEqual(wire.scope, undefined);
assert.deepEqual(wire.block[0], [[SexpOpcodes.Append,[SexpOpcodes.GetSymbol,0,["message"]]]])
assert.deepEqual(wire.block[0], [
[SexpOpcodes.Append, [SexpOpcodes.GetSymbol, 0, ['message']]],
]);
});
});
1 change: 0 additions & 1 deletion packages/@glimmer-workspace/integration-tests/test/ember-component-test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2160,7 +2160,6 @@ class CurlyBoundsTrackingTest extends CurlyTest {

assert.ok(instance, 'instance is created');


this.assertEmberishElement('span', {}, 'foo bar');

const { bounds, element } = instance.captured;
Expand Down
Loading

0 comments on commit 921cda6

Please sign in to comment.