Refactor exhaustiveness checking #4303
Open
+1,217
−1,262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite big change refactoring the pattern matching compilation code.
exhaustiveness.rs
one. Most notably,Pattern
was moved thereMatch
data structure hasn't changed much. The code consuming the result of the compilation hasn't been touched by this refactoring. However, I've tried to make the public facing api easier to use; as a result, I think that now the code intype_/expression.rs
is a lot nicerAfter this refactoring gets merged I will move on to deal with compilation of string patterns (and maybe bit arrays as well!), and finally we could start using the tree for code generation on the js target