Implement renaming for Functions, Constants and Type Variants #4282
Conversation
GearsDatapacks
force-pushed
the
cross-module-value-renaming
branch
3 times, most recently
from
d4c87d0 to
1f931b9
Compare
|
Ok, this is ready for review now. I'm not super happy with the way I fixed the module access shadowing bug, but I couldn't think of another way to do it. Let me know if you have any thoughts. |
| import mod.{Constructor} | ||
|
|
||
| pub fn main() { | ||
| #(Constructor(75), mod.Constructor(57)) |
There was a problem hiding this comment.
I wonder if when renaming a constructor that has been imported in an unqualified fashion it should alias the import rather than rename it globally.
There was a problem hiding this comment.
Yeah, I wasn't sure about this. Maybe we can ask in Discord and hear other people's opinions on it.
compiler-core/src/ast.rs
Outdated
| #[derive(Debug, Clone, PartialEq, Eq, Default)] | ||
| pub struct References { | ||
| pub imported_modules: HashSet<EcoString>, | ||
| pub value_references: HashMap<(EcoString, EcoString), Vec<SrcSpan>>, |
There was a problem hiding this comment.
It seems like it may be challenging to identify unused code with this data structure, and replacing the current broken usage tracking system is one of the main goals of the call graph work. Did you have thoughts on how that'd be done?
There was a problem hiding this comment.
That's true, I wasn't thinking too much about the current usage tracking. We already generate an in-module call-graph for dependency ordering, so would it be possible to use just that for usage tracking? We can't use that for renaming because it doesn't track cross-module usage.
There was a problem hiding this comment.
That one only tracks calls to module functions, which isn't enough for usage detection.
Usage detection, rename, and show-references all require the same thing: knowing all the references for each entity in the code. Usage detection uses this information differently from the other two though, it traverses the graph from all the public entities to find any unreachable nodes.
There was a problem hiding this comment.
Ok that makes sense, thanks.
I'll look into it
|
Ok, I have now added the reference information to the cache so we can rename values in cached modules. |
GearsDatapacks
force-pushed
the
cross-module-value-renaming
branch
5 times, most recently
from
237dbeb to
08d5d5c
Compare
GearsDatapacks
force-pushed
the
cross-module-value-renaming
branch
from
08d5d5c to
aa0d57e
Compare
This PR closes #3259
This is pretty much ready, except for two things: