-
-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement variable sized bit array pattern matching on JavaScript #4273
Implement variable sized bit array pattern matching on JavaScript #4273
Conversation
7debf3d
to
312c90b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful, thank you!!!
I've left a bunch of little nit-pick notes inline, and it would be fab to remove all the clones.
I couldn't see any tests that involve extra, and there's no integration tests to check that that the runtime behaviour is correct. Here's an example bit array PR's integration tests: https://github.com/gleam-lang/gleam/pull/3946/files#diff-42aefabdf30f6176dcac76f43f95e6af038909579ce30683824c7fc2d98c3db9
Thanks again!
9115deb
to
e62a1bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful work, as always! Thank you!!
What should I do about the linter errors? Should I use the shorthand |
Ah, looks like tests are failing due to #3253. I guess I just have to work around that for now? |
Reworking the test to avoid that bug could be good |
Head branch was pushed to by a user without write access
Oops, forgot 928 doesn't fit within 8 bits |
Head branch was pushed to by a user without write access
Ok sorry this has been a bit of a mess. Should be ready to merge now |
35ec68d
to
1b7d1f3
Compare
I've decided to follow your comment and replace the usage of |
e861c8c
to
43b5974
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!! Thank you!
This PR implements the ability to pattern match on dynamically sized bit array segments on JavaScript.