Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust 1.85 and Rust Edition 2024 #4270

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

GearsDatapacks
Copy link
Member

This PR is quite big as it's a lot of automated style and formatting changes

@GearsDatapacks
Copy link
Member Author

Weird. Seems like a couple of the checks are running on rust 1.84.1 and not 1.85

@GearsDatapacks GearsDatapacks force-pushed the rust-1.85 branch 3 times, most recently from 117c2f8 to c17a9ce Compare February 21, 2025 10:25
@GearsDatapacks GearsDatapacks marked this pull request as draft February 21, 2025 11:36
@GearsDatapacks GearsDatapacks force-pushed the rust-1.85 branch 7 times, most recently from 5f098ef to e07c904 Compare February 26, 2025 09:38
@GearsDatapacks
Copy link
Member Author

Aha! Looks like checks are finally passing. This is ready for review now

@GearsDatapacks GearsDatapacks marked this pull request as ready for review February 27, 2025 09:58
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

That removal of else if let is a bit unfortunately for the amount of nesting in the parser. Maybe we'll revisit that at some point.

@lpil lpil merged commit 8d19869 into gleam-lang:main Feb 27, 2025
12 checks passed
@GearsDatapacks GearsDatapacks deleted the rust-1.85 branch February 27, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants