Fix generation of package interface when modules are cached #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GearsDatapacks
force-pushed
the
package-interface
branch
3 times, most recently
from
2087f6d to
16b4100
Compare
lpil
reviewed
Feb 26, 2025
|
All your comments/questions should now be resolved. I've moved the |
GearsDatapacks
force-pushed
the
package-interface
branch
from
ac899bf to
3265132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows on from #3669 and fixes #2898.
It uses partly the same approach of using the
ModuleInterface(the part which is cached) to generate the package interface, rather than the AST. However, this is implemented in such a way that the cached modules do not need to be cloned when doing so.