Skip to content

Commit

Permalink
Align tsconfig.json files
Browse files Browse the repository at this point in the history
* order of elements but also values:
* module: nodeNext, moduleResolution: nodeNext, esModuleInterop: true, resolveJsonModule: true
* tichu-term-client still uses commonjs for now (#829)
  • Loading branch information
Gregory Joseph committed Dec 13, 2024
1 parent e5ac888 commit 2daface
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 22 deletions.
19 changes: 11 additions & 8 deletions tichu-clients/packages/tichu-client-ts-lib/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
{
"compilerOptions": {
"target": "es2023", // when we had es2019, we left a comment to say that: Node doesn't understand nullish coalescing or optional chaining, so instruct ts to transpile
"target": "es2023",
"module": "nodenext",
"moduleResolution": "nodenext",
"esModuleInterop": true,
"resolveJsonModule": true,
"lib": ["es2023", "dom"],
"types": ["node", "fs-extra"],

"allowJs": false,
"declaration": true,
"declarationMap": true,
"experimentalDecorators": true,
"outDir": "./lib",
"rootDir": "./src",
"importHelpers": true,
"strict": true,
"types": ["node", "fs-extra"],
"esModuleInterop": false,
"moduleResolution": "nodenext",
"resolveJsonModule": true,
"importHelpers": true

"outDir": "./lib",
"rootDir": "./src"
},
"exclude": ["node_modules", "lib", "templates"]
}
19 changes: 11 additions & 8 deletions tichu-clients/packages/tichu-term-client/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
{
"compilerOptions": {
"target": "es2023", // when we had es2019, we left a comment to say that: Node doesn't understand nullish coalescing or optional chaining, so instruct ts to transpile
"target": "es2023",
"module": "commonjs",
"moduleResolution": "node",
"esModuleInterop": true,
"resolveJsonModule": true,
"lib": ["es2023", "dom"],
"types": ["node", "fs-extra"],

"allowJs": false,
"declaration": true,
"declarationMap": true,
"experimentalDecorators": true,
"outDir": "./lib",
"rootDir": "./src",
"importHelpers": true,
"strict": true,
"types": ["node", "fs-extra"],
"esModuleInterop": true,
"moduleResolution": "node",
"resolveJsonModule": true,
"importHelpers": true

"outDir": "./lib",
"rootDir": "./src"
},
"exclude": ["node_modules", "lib", "templates"]
}
21 changes: 15 additions & 6 deletions tichu-clients/packages/tichu-web/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,27 @@
{
"compilerOptions": {
"target": "es2023",
"module": "nodenext",
"moduleResolution": "nodenext",
"esModuleInterop": true,
"resolveJsonModule": true,
"lib": ["dom", "dom.iterable", "esnext"],
"types": ["vite/client", "vite-plugin-svgr/client"],
"allowJs": true,

"allowJs": false,
"declaration": true,
"declarationMap": true,
"experimentalDecorators": true,
"importHelpers": true,
"strict": true,

"outDir": "./lib",
"rootDir": "./src",

"skipLibCheck": true,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"strict": true,
"forceConsistentCasingInFileNames": true,
"noFallthroughCasesInSwitch": true,
"module": "nodenext",
"moduleResolution": "nodenext",
"resolveJsonModule": true,
"isolatedModules": true,
"noEmit": true,
"jsx": "react-jsx"
Expand Down

0 comments on commit 2daface

Please sign in to comment.