Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affirm that gitdb and smmap advisories can also be created #1991

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

EliahKagan
Copy link
Contributor

This expands SECURITY.md to affirm the claims in the new SECURITY.md files in gitdb and smmap that vulnerabilities found in them can be reported in the GitPython repository with the same link as one would use to report a GitPython vulnerability, as well as to note how the distinction between affected package can be specified when it is known at the time a vulnerability is reported.

Along with gitpython-developers/smmap#59 and gitpython-developers/gitdb#117, this fixes gitpython-developers/gitdb#116.

@EliahKagan EliahKagan force-pushed the gitdb-smmap-security branch from 770e4b8 to 0459b9a Compare January 5, 2025 08:36
@EliahKagan EliahKagan changed the title Affirm that gitdb and smmap advisories can also be crated Affirm that gitdb and smmap advisories can also be created Jan 5, 2025
This expands `SECURITY.md` to affirm the claims in the new
`SECURITY.md` files in gitdb and smmap that vulnerabilities found
in them can be reported in the GitPython repository with the same
link as one would use to report a GitPython vulnerability, as well
as to note how the distinction between affected package can be
specified when it is known at the time a vulnerability is reported.

Along with gitpython-developers/smmap#59
and gitpython-developers/gitdb#117, this
fixes gitpython-developers/gitdb#116.
@EliahKagan EliahKagan force-pushed the gitdb-smmap-security branch from 0459b9a to b20de09 Compare January 5, 2025 08:43
@EliahKagan
Copy link
Contributor Author

EliahKagan commented Jan 5, 2025

The setup-wsl action failed on Windows in Python 3.12 here (here's the log). It is extremely unlikely to relate to the actual change in this PR, which modifies only SECURITY.md. I've done a no-change amend and forced pushed to achieve the effect of rerunning the tests, which I expect to pass.

I do wonder if Alpine Linux for WSL is more likely to have this problem than Debian, which was used before and which I believe setup-wsl still downloads from a different source.

Edit: Hmm, actually, it failed both in my fork on the push trigger and here on the pull-request trigger:

This is odd because it only failed with Python 3.12. But as far as I know, setup-wsl should not be using Python in any way!

One possibility is that there was a temporary outage in access to the download, and that because this push was after the PR was opened (it was a force push to fix a typo), the jobs started at almost the same time, and thus reached that step at almost the same time, where they both encountered the transient error at the same time.

Edit 2: It reran successfully.

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this will do perfectly!

@Byron Byron merged commit 206201c into gitpython-developers:main Jan 5, 2025
22 checks passed
@EliahKagan EliahKagan deleted the gitdb-smmap-security branch January 5, 2025 16:41
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull request Jan 5, 2025
The links in gitpython-developers#1991 did not work, as I got the branch names wrong.
@EliahKagan
Copy link
Contributor Author

Actually, the links I added are broken! The branch name part of the URLs is wrong, so they give not-found errors. (I had tested the links from gitdb and smmap to here, but not the ones here to gitdb and smmap.) I've opened #1992 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unclear what security policy would apply to gitdb and smmap vulnerabilities
2 participants