Code

Issue and test deprecation warnings#1886

Code

Merged

Byron merged 89 commits intogitpython-developers:maingitpython-developers/GitPython:mainfrom EliahKagan:deprecation-warningsEliahKagan/GitPython:deprecation-warningsCopy head branch name to clipboardMar 31, 2024

+1,257-63

Commits

Commits on Mar 28, 2024

• Test that deprecated Diff.renamed property warns

  Show description for 2382891
  EliahKagan

  committed
  2382891

  Copy full SHA for 2382891

• Have the deprecated Diff.renamed property issue a warning

  EliahKagan

  committed
  e7dec7d

  Copy full SHA for e7dec7d

• Fix exception in Popen.__del__ in test on Windows

  Show description for a8f109c
  EliahKagan

  committed
  a8f109c

  Copy full SHA for a8f109c

• Test that the preferred renamed_file property does not warn

  EliahKagan

  committed
  fffa6ce

  Copy full SHA for fffa6ce

• Add a TODO for simplifying the single_diff fixture

  EliahKagan

  committed
  bc111b7

  Copy full SHA for bc111b7

• Decompose new fixture logic better

  Show description for e3728c3
  EliahKagan

  committed
  e3728c3

  Copy full SHA for e3728c3

• Extract no-deprecation-warning asserter as a context manager

  Show description for ff4b58d
  EliahKagan

  committed
  ff4b58d

  Copy full SHA for ff4b58d

• Test that the deprecated Commit.trailers property warns

  Show description for 2c52696
  EliahKagan

  committed
  2c52696

  Copy full SHA for 2c52696

• Have the deprecated Commit.trailers property issue a warning

  EliahKagan

  committed
  03464d9

  Copy full SHA for 03464d9

• Test that Traversable.{list_,}traverse, but not overrides, warn

  EliahKagan

  committed
  9d096e0

  Copy full SHA for 9d096e0

• Use the :exc: Sphinx role for DeprecationWarning

  Show description for 21c2b72
  EliahKagan

  committed
  21c2b72

  Copy full SHA for 21c2b72

• Test that subclassing deprecated git.util.Iterable warns

  Show description for ca385a5
  EliahKagan

  committed
  ca385a5

  Copy full SHA for ca385a5

• Call repo.close() instead of manually collecting

  Show description for 8bbcb26
  EliahKagan

  committed
  8bbcb26

  Copy full SHA for 8bbcb26

• Better name and document the basic deprecation test module

  Show description for b8ce990
  EliahKagan

  committed
  b8ce990

  Copy full SHA for b8ce990

Commits on Mar 29, 2024

• Annotate basic deprecation tests; have mypy scan it

  Show description for 61273aa
  EliahKagan

  committed
  61273aa

  Copy full SHA for 61273aa

• Start on top-level module attribute access regression tests

  EliahKagan

  committed
  b7a3d8c

  Copy full SHA for b7a3d8c

• Test attribute access and importing separately

  Show description for 105f500
  EliahKagan

  committed
  105f500

  Copy full SHA for 105f500

• Expand to test top-level deprecated names

  EliahKagan

  committed
  859e38c

  Copy full SHA for 859e38c

• Hoist import git to module level in test module

  Show description for 46a739d
  EliahKagan

  committed
  46a739d

  Copy full SHA for 46a739d

• Test static typing of private module aliases

  Show description for a2df3a8
  EliahKagan

  committed
  a2df3a8

  Copy full SHA for a2df3a8

• Improve a couple test case docstrings

  EliahKagan

  committed
  a15a830

  Copy full SHA for a15a830

• Add a couple missing assert keywords

  EliahKagan

  committed
  dbaa535

  Copy full SHA for dbaa535

• Clarify how test_private_module_aliases is statically checkable

  EliahKagan

  committed
  d00c843

  Copy full SHA for d00c843

• Move mark-sharing tests into a class

  EliahKagan

  committed
  983fda7

  Copy full SHA for 983fda7

• Add FIXME for what to do next

  EliahKagan

  committed
  19acd4c

  Copy full SHA for 19acd4c

• Fix a test docstring

  EliahKagan

  committed
  f39bbb5

  Copy full SHA for f39bbb5

• Test resolution into git.index.util using git.util

  EliahKagan

  committed
  aee7078

  Copy full SHA for aee7078

• Fix brittle way of checking warning messages

  Show description for 7f4a191
  EliahKagan

  committed
  7f4a191

  Copy full SHA for 7f4a191

• Clarify todo

  EliahKagan

  committed
  d08a576

  Copy full SHA for d08a576

• Start reorganizing new tests more in the GitPython style

  EliahKagan

  committed
  9d58e6d

  Copy full SHA for 9d58e6d

• Finish reorganizing; fix assertion for duplicated messages

  Show description for 45c128b
  EliahKagan

  committed
  45c128b

  Copy full SHA for 45c128b

• Add imports so pyright recognizes refs and index

  Show description for 247dc15
  EliahKagan

  committed
  247dc15

  Copy full SHA for 247dc15

• Expand and clarify test module docstring

  Show description for b05963c
  EliahKagan

  committed
  b05963c

  Copy full SHA for b05963c

• Tiny import tweak

  EliahKagan

  committed
  074bbc7

  Copy full SHA for 074bbc7

• Pick a better name for _MODULE_ALIAS_TARGETS

  Show description for 18608e4
  EliahKagan

  committed
  18608e4

  Copy full SHA for 18608e4

• Use typing_extensions only if needed

  Show description for 1f290f1
  EliahKagan

  committed
  1f290f1

  Copy full SHA for 1f290f1

• Fix zip calls

  Show description for 7a4f7eb
  EliahKagan

  committed
  7a4f7eb

  Copy full SHA for 7a4f7eb

• Fix (and improve wording) of docstrings

  EliahKagan

  committed
  5977a6e

  Copy full SHA for 5977a6e

• Remove extra import "from typing_extensions"

  EliahKagan

  committed
  5b1fa58

  Copy full SHA for 5b1fa58

• Start on test_compat

  Show description for a07be0e
  EliahKagan

  committed
  a07be0e

  Copy full SHA for a07be0e

• Expand to test all three is_<platform> aliases

  EliahKagan

  committed
  d4917d0

  Copy full SHA for d4917d0

• Slightly improve docstrings

  EliahKagan

  committed
  f4e5f42

  Copy full SHA for f4e5f42

• Add test of dir() on git.compat

  EliahKagan

  committed
  d54f851

  Copy full SHA for d54f851

• Add static type assertions to is_platform test

  EliahKagan

  committed
  aaf046a

  Copy full SHA for aaf046a

• Refactor test_compat.test_dir for clarity

  EliahKagan

  committed
  84d734d

  Copy full SHA for 84d734d

• Add top-level dir() tests

  EliahKagan

  committed
  3a621b3

  Copy full SHA for 3a621b3

• Remove old comment meant as todo (that was done)

  EliahKagan

  committed
  05e0878

  Copy full SHA for 05e0878

• Test that top-level aliases point to modules with normal __name__

  EliahKagan

  committed
  3fe2f15

  Copy full SHA for 3fe2f15

• Use names directly on other tests

  Show description for 246cc17
  EliahKagan

  committed
  246cc17

  Copy full SHA for 246cc17

• Fix a small docstring typo

  EliahKagan

  committed
  d7b6b31

  Copy full SHA for d7b6b31

• Improve description in test module docstrings

  EliahKagan

  committed
  96089c8

  Copy full SHA for 96089c8

• Start on test_types

  EliahKagan

  committed
  a0ef537

  Copy full SHA for a0ef537

• Explain substring assertions in test_toplevel

  EliahKagan

  committed
  52e7360

  Copy full SHA for 52e7360

• Expand Lit_commit_ish test name and write docstring

  EliahKagan

  committed
  e3675a0

  Copy full SHA for e3675a0

• Clarify test_compat.test_dir

  EliahKagan

  committed
  4857ff0

  Copy full SHA for 4857ff0

• Add test of dir() on git.types

  EliahKagan

  committed
  488cc13

  Copy full SHA for 488cc13

• Clarify comment about is_<platform> value assertions

  EliahKagan

  committed
  19b3c08

  Copy full SHA for 19b3c08

• Issue warnings for some deprecated attributes of modules

  EliahKagan

  committed
  28bd4a3

  Copy full SHA for 28bd4a3

• Refine deprecated module attributes and their warnings

  Show description for dffa930
  EliahKagan

  committed
  dffa930

  Copy full SHA for dffa930

• Start on test module about Git.USE_SHELL and Git attributes

  EliahKagan

  committed
  7ab27c5

  Copy full SHA for 7ab27c5

• Make test_use_shell_on_class more robust

  EliahKagan

  committed
  af723d5

  Copy full SHA for af723d5

• Write most remaining Git attribute/deprecation tests

  EliahKagan

  committed
  bf13888

  Copy full SHA for bf13888

• Begin multiprocessing misadventure

  Show description for 602de0c
  EliahKagan

  committed
  602de0c

  Copy full SHA for 602de0c

• Somewhat clarify multiprocessing misadventure

  EliahKagan

  committed
  d4b50c9

  Copy full SHA for d4b50c9

• Discuss multiprocessing in test module docstring; remove bad test

  EliahKagan

  committed
  02c2f00

  Copy full SHA for 02c2f00

• Discuss metaclass conflicts in test module docstring

  EliahKagan

  committed
  46df79f

  Copy full SHA for 46df79f

• Revise test module docstring for clarity

  EliahKagan

  committed
  40ed842

  Copy full SHA for 40ed842

• Test that USE_SHELL is unittest.mock.patch patchable

  EliahKagan

  committed
  6a35261

  Copy full SHA for 6a35261

• Make the restore_use_shell_state fixture more robust

  EliahKagan

  committed
  e725c82

  Copy full SHA for e725c82

• Add type: ignore in test that we can't set USE_SHELL on instances

  Show description for 436bcaa
  EliahKagan

  committed
  436bcaa

  Copy full SHA for 436bcaa

• Clarify unittest.mock.patch patchability test docstring

  EliahKagan

  committed
  febda6f

  Copy full SHA for febda6f

• Test that Git.execute's own read of USE_SHELL does not warn

  Show description for 4037108
  EliahKagan

  committed
  4037108

  Copy full SHA for 4037108

• Suppress type errors in restore_use_shell_state _USE_SHELL branches

  Show description for 0e311bf
  EliahKagan

  committed
  0e311bf

  Copy full SHA for 0e311bf

• Fix wrong/unclear grammar in test_instance_dir docstring

  EliahKagan

  committed
  df4c5c0

  Copy full SHA for df4c5c0

• Issue warnings whenever Git.USE_SHELL is accessed

  Show description for d38e721
  EliahKagan

  committed
  d38e721

  Copy full SHA for d38e721

• Implement instance USE_SHELL lookup in __getattr__

  Show description for 05de5c0
  EliahKagan

  committed
  05de5c0

  Copy full SHA for 05de5c0

• Have USE_SHELL warn but work like normal via super()

  Show description for 04eb09c
  EliahKagan

  committed
  04eb09c

  Copy full SHA for 04eb09c

• Keep mypy from thinking Git has arbitrary class attributes

  Show description for c6f518b
  EliahKagan

  committed
  c6f518b

  Copy full SHA for c6f518b

• Clarify that the private name mangling is intentional

  EliahKagan

  committed
  c5d5b16

  Copy full SHA for c5d5b16

• Read USE_SHELL in Git.execute without DeprecationWarning

  Show description for 84bf2ca
  EliahKagan

  committed
  84bf2ca

  Copy full SHA for 84bf2ca

• Add GitPython project top comments to new test modules

  EliahKagan

  committed
  5bef7ed

  Copy full SHA for 5bef7ed

• Hide del util from type checkers

  Show description for 3da47c2
  EliahKagan

  committed
  3da47c2

  Copy full SHA for 3da47c2

• Expand USE_SHELL docstring; clarify a test usage

  Show description for bdabb21
  EliahKagan

  committed
  bdabb21

  Copy full SHA for bdabb21

• Explain the approach in test.deprecation to static checking

  Show description for b51b080
  EliahKagan

  committed
  b51b080

  Copy full SHA for b51b080

Commits on Mar 30, 2024

• Make test.performance.lib docstring more specific

  Show description for 7cd3aa9
  EliahKagan

  committed
  7cd3aa9

  Copy full SHA for 7cd3aa9

• Make/use test.deprecation.lib; abandon idea to filter by module

  Show description for cf2576e
  EliahKagan

  committed
  cf2576e

  Copy full SHA for cf2576e

Commits on Mar 31, 2024

• Clarify security risk in USE_SHELL doc and warnings

  EliahKagan

  committed
  f92f4c3

  Copy full SHA for f92f4c3

• Test GitMeta alias

  EliahKagan

  committed
  8327b45

  Copy full SHA for 8327b45

• Add GitMeta alias

  Show description for f6060df
  EliahKagan

  committed
  f6060df

  Copy full SHA for f6060df