Fix #40 #41
Open
Fix #40 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise all the error handling in that func goes to waste since no one will see it. It seems `Warnf` is the best we have
The deprecations are since go 1.16 and the workflows/release.yaml says 1.18 and higher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This keeps track of the allocated host ports in the
docker runcommand and reports conflicts with (as best it can) where they came from. Related to that, in actually checks that theport:value in.gitpod.ymlis in fact anintrather than just assuming it so. Finally, it also stops swallowing err from the actual Start Workspace invocationRelated Issue(s)
Fixes #40
How to test
main.gitpod.ymlRelease Notes
Documentation