Add support for pasting all supported inline tags #90
Conversation
- bold - italic - inline code - kbd - strike - insert - superscript - subscript
src/markdown.ts
Outdated
There was a problem hiding this comment.
Created this new file to standardize the building of the Markdown strings.
Note: I had to disable lint errors because we are not escaping the contents. This is consistent with existing building of link/image/HTML strings, but an argument could be made that we should escape the contents. Not for XSS aversion (this text is going into a textarea so it won't be run directly) but just to make the output more versatile to complex input. But this is more difficult than just HTML escaping - we would also need to escape Markdown special characters... I decided to leave this for the future.
src/paste-markdown-html.ts
Outdated
| @@ -95,6 +106,29 @@ function convertToMarkdown(plaintext: string, walker: TreeWalker): string { | |||
| return index === NODE_LIMIT ? plaintext : markdown | |||
| } | |||
|
|
|||
| function getNodeMarkdownBuilder(node: Node): (() => string) | void { | |||
There was a problem hiding this comment.
This function returns a function to make it lazy. This allows us to see if we support converting a specific Node without actually spending the energy to convert it.
| @@ -95,6 +106,29 @@ function convertToMarkdown(plaintext: string, walker: TreeWalker): string { | |||
| return index === NODE_LIMIT ? plaintext : markdown | |||
| } | |||
|
|
|||
| function getNodeMarkdownBuilder(node: Node): (() => string) | void { | |||
| if (node instanceof HTMLAnchorElement) return () => linkify(node) | |||
There was a problem hiding this comment.
links must be specialcased to get access to the href property on the instance
| @@ -62,9 +73,7 @@ function convertToMarkdown(plaintext: string, walker: TreeWalker): string { | |||
| // Walk through the DOM tree | |||
| while (currentNode && index < NODE_LIMIT) { | |||
| index++ | |||
| const text = isLink(currentNode) | |||
| ? (currentNode.textContent || '').replace(/[\t\n\r ]+/g, ' ') | |||
There was a problem hiding this comment.
This line break stripping is still done, just later in the process
|
👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Primer first responder will review it soon.
|
iansan5653
force-pushed
the
more-tags
branch
from
0419da1 to
3ca15b1
Compare
iansan5653
force-pushed
the
more-tags
branch
from
c2271a9 to
36aa4cd
Compare
|
Didn't manage to make it work and won't have capacity to revisit for a while, so I'm going to close this out. |
As discussed in #67, this PR adds support for keeping the formatting provided by supported inline HTML elements.
This includes the following:
not bold <strong>bold</strong> not boldnot bold **bold** not boldnot italic <em>italic</em> not italicnot italic *italic* not italicnot strikethrough <del>strikethrough</del> not strikethroughnot strikethrough ~~strikethrough~~ not strikethroughstrikethroughnot strikethroughnot code <code>code</code> not codenot code `code` not codecodenot codenot kbd <kbd>kbd</kbd> not kbdnot kbd <kbd>kbd</kbd> not kbdnot sup <sup>sup</sup> not supnot sup <sup>sup</sup> not supnot sub <sub>sub</sub> not subnot sub <sub>sub</sub> not subnot ins <ins>ins</ins> not insnot ins <ins>ins</ins> not insI left out the block tags from the issue because these require special handling (adding line breaks) and I didn't want to make this PR too big.