Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: Enable diff-informed queries #18528

Merged
merged 7 commits into from
Jan 20, 2025
Merged

JS: Enable diff-informed queries #18528

merged 7 commits into from
Jan 20, 2025

Conversation

asgerf
Copy link
Contributor

@asgerf asgerf commented Jan 17, 2025

The first commit is an auto-generated patch that enables diff-informed data flow in the obvious cases, and inserts a TODO comment in the non-obvious cases.

Those TODOs are then fixed up in the second commit.

Evaluation shows up to 88% speedup, with a median of 15% speedup.

@asgerf asgerf force-pushed the jss/diff-informed branch from 3b63d18 to 683ebca Compare January 20, 2025 10:20
@asgerf asgerf added the no-change-note-required This PR does not need a change note label Jan 20, 2025
@asgerf asgerf marked this pull request as ready for review January 20, 2025 10:24
@Copilot Copilot bot review requested due to automatic review settings January 20, 2025 10:24
@asgerf asgerf requested a review from a team as a code owner January 20, 2025 10:24

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.

Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@asgerf asgerf merged commit f319003 into github:main Jan 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JS no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants