JS: Add view-component-input threat model #18466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
force-pushed
the
js/view-component-inputs
branch
3 times, most recently
from
ca410fe to
f0fe3c1
Compare
asgerf
force-pushed
the
js/view-component-inputs
branch
from
f0fe3c1 to
c329336
Compare
This reverts commit 6954039.
asgerf
force-pushed
the
js/view-component-inputs
branch
from
c329336 to
4161f45
Compare
There was a problem hiding this comment.
Copilot reviewed 16 out of 34 changed files in this pull request and generated no comments.
Files not reviewed (18)
- docs/codeql/reusables/threat-model-description.rst: Language not supported
- javascript/ql/lib/semmle/javascript/Concepts.qll: Language not supported
- javascript/ql/lib/semmle/javascript/ViewComponentInput.qll: Language not supported
- javascript/ql/lib/semmle/javascript/frameworks/Angular2.qll: Language not supported
- javascript/ql/lib/semmle/javascript/frameworks/React.qll: Language not supported
- javascript/ql/lib/semmle/javascript/frameworks/Vue.qll: Language not supported
- javascript/ql/lib/semmle/javascript/security/dataflow/CommandInjectionCustomizations.qll: Language not supported
- javascript/ql/lib/semmle/javascript/security/dataflow/CorsMisconfigurationForCredentialsCustomizations.qll: Language not supported
- javascript/ql/lib/semmle/javascript/security/dataflow/LogInjectionQuery.qll: Language not supported
- javascript/ql/lib/semmle/javascript/security/dataflow/RegExpInjectionCustomizations.qll: Language not supported
- javascript/ql/lib/semmle/javascript/security/dataflow/RemoteFlowSources.qll: Language not supported
- javascript/ql/lib/semmle/javascript/security/dataflow/RequestForgeryCustomizations.qll: Language not supported
- javascript/ql/lib/semmle/javascript/security/dataflow/ResourceExhaustionCustomizations.qll: Language not supported
- javascript/ql/lib/semmle/javascript/security/dataflow/TaintedPathCustomizations.qll: Language not supported
- javascript/ql/src/meta/alerts/TaintSources.ql: Language not supported
- javascript/ql/src/meta/alerts/ThreatModelSources.ql: Language not supported
- javascript/ql/src/meta/internal/TaintMetrics.qll: Language not supported
- javascript/ql/test/library-tests/frameworks/Angular2/test.expected: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes get requests from users to treat React props, Vue props, or Angular inputs as taint sources. Such inputs are not true taint sources however, and tend to generate many false positives in practice if used as taint sources. These inputs are akin to function parameters in that they just hold whatever values are passed in at the component's instantiation site.
As a middle ground, this PR adds a new threat model kind called
view-component-input. When enabled, React props, Vue props, and Angular2 inputs are seen as taint sources.Also adds a new meta-query to report changes to threat model sources other than
remote.Evaluations:
booleanornumbergets filtered out.