backport checks changes to v2 branch #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityasharad
approved these changes
Dec 20, 2023
aeisenberg
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
I think this works. Though, is there a benefit to running the checks on a different node version on v2? I was imagining that when the matrix value is not current, then the job can just trivially end in success. If there's a reason to run on both versions, then let's do it.
| NODE_TYPES_VERSION: ${{ matrix.node-types-version }} | ||
| run: | | ||
| # Export `NODE_TYPES_VERSION` so it's available to jq | ||
| export NODE_TYPES_VERSION="${NODE_TYPES_VERSION}" |
There was a problem hiding this comment.
I didn't know this was necessary.
Pretty sure this works the same:
Suggested change
| export NODE_TYPES_VERSION="${NODE_TYPES_VERSION}" | |
| export NODE_TYPES_VERSION |
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Lint | ||
| run: npm run-script lint | ||
|
|
||
| - name: Update version of @types/node | ||
| if: matrix.node-types-version != 'current' | ||
| env: |
There was a problem hiding this comment.
Suggested change
| env: | |
| shell: bash | |
| env: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to keep alignment of check names across all the maintained branches, we backport the matrix job to the
releases/v2branch.The check runs on node 16 and skips for the current version (node 20).
Merge / deployment checklist