-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare a base for i18n #131
Conversation
Simply move translated pages to /LOCALE/ will cause: - broken links - broken images This is because: - The default layouts assume resources are located in the root directory. - In content pages, some links link to the root directory also. This commit fix the above problems and add a example of /LOCALE/, i.e. /en/, which can be used as the base for i18N.
Got a screenshot of what the breadcrumb looks like with this change? Also, English should be the default language. What would I see if I visit http://choosealicense.com or http://choosealicense.com/about with this change? |
@haacked For Demo, See http://weakish.gitcafe.com/en/
I didn't touch these pages. I hope |
So in the English case, we'd have to duplicate every change we made. I'm not a fan of that. Jekyll has a new Data Files feature. I wonder if it wouldn't make more sense to leverage that somehow. For example, have translations in a data file and figure out a way to pipe them into existing templates. I'm totally ✋ 👋ing here as I haven't really thought this through. But copying HTML files is going to be a royal pain because the content changes a lot! |
@haacked Data Files is for customizing templates, not for content of pages. I am afraid that copying HTML files cannot be avoided, since Jekyll itself does not support i18N. We can make a script to automate this, though. |
Sure, but couldn't we use it for content? Nothing prevents that, right? |
That's not an option. That'd be a maintenance nightmare.
Let's fix that. @parkr what do you think about adding an
|
This is main issue about translate site to other languages? I am very interested in translation site to Russian. Realties have any shifts in establishing mechanisms to transfer? |
@serieznyi I agree with you. I have tlanslated old version of this project. But I'm holding now. Because there are no explicit solution until now. I hope find a way for I18N. |
Would still love to see this happen, but don't know that we have a clean path forward and may need to wait until Jekyll-core (or perhaps a Jekyll plugin) adds support. Commented over in jekyll/jekyll#1809 to hopefully see that happen. Specifically, I'd love some mechanism by which we wouldn't have to change everything (e.g., a site would work out fo the box), but where a translation existed, it could generate that translation, falling back to the default language. Put another way, any current Jekyll site should be ready to translation with the addition of a language, not through abstraction into, e.g., |
+1 |
What about the text of the licenses themselves? Are there official translations of the MIT license? |
IMO the possible choices (to avoid copying duplicated pages) are:
AFAIK, only Creative Commons have official translations. |
@weakish Thanks for all the work you put into this. It seems like there is not a great path forward right now. That issue along with the lack of official translations makes it seem like this isn't likely to move forward right now. I'm going to close this for now. We're happy to reconsider if someone is interested in putting in the work to make this happen, but it's not a priority for us right now. |
Simply move translated pages to /LOCALE/ will cause:
This is because:
directory.
This commit fix the above problems and add a example of /LOCALE/,
i.e. /en/, which can be
used as the base for i18N.
See #68