-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lobster language support #7204
base: main
Are you sure you want to change the base?
Lobster language support #7204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really don't need that many samples. 2-3 of the most representative of common usage is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A cached copy of the grammars licence should have been created when you ran the script/add-grammar
command. This file needs to be included in this PR.
I added a license file. Also I did re-upload https://github.com/inferrna/lobster_ling repo. Originally it was a fork of https://github.com/aardappel/lobster which seemed a little too much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert your last two changes. Submodule names are based on the upstream repo name. Your upstream repo is still lobster_ling
so the submodule name should remain lobster_ling
too. If you want to rename the submodule, rename your repo and re-add the grammar.
PR looks good now. The language isn't popular enough for inclusion yet so I'll leave this pending popularity and review. Popularity is re-assessed each time a new release is made (~ every 3-4 months). This issue will not be updated with each check and there's no need to keep merging master in but please keep an eye on the PR and address any conflicts if they crop up. |
Description
#f95428