Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register bun.lock as JSON #7193

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

RiskyMH
Copy link

@RiskyMH RiskyMH commented Jan 7, 2025

Description

Bun recently added a text lockfile called bun.lock (https://bun.sh/blog/bun-lock-text-lockfile) and it will soon become default.

It is also expected to only have one bun.lock file at root. At time of writing there was at least 200 repos (and still quickly growing), but it seems like github search count randomly fluctuates +/- around ~30 results.

Checklist:


Although bun.lock officially uses JSONC, this PR sets it to standard JSON. Bun only relies on the trailing comma feature, which JSON happens to support without errors. The main reason to use standard JSON is that it provides better syntax highlighting on GitHub (#6197)

@RiskyMH RiskyMH requested a review from a team as a code owner January 7, 2025 11:07
@RiskyMH
Copy link
Author

RiskyMH commented Jan 16, 2025

Hi @lildude, thanks for reviewing this PR 🙏.

GitHub search seems to be inconsistent with the result count—it’s fluctuated a lot recently. From what I can tell, there are at least 220 repositories using bun.lock, which meets the minimum requirements. Each repo typically has only one lockfile, even in monorepo setups with bun.lock at the root.

The fluctuations seem to be a search or caching issue rather than a decline in usage. Adoption is expected to grow significantly soon, as bun.lock will become the default for new projects in Bun 1.2. However we would love it if JSON highlighting could be default by then!

ignore above, it appears to have calmed down and show 200+ repos consistently.

--

The search is currently showing the correct number again, so I’d appreciate it if you could take another look:
https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*bun.lock+lockfileVersion+NOT+org%3Aoven-sh

Thank you! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants