Add ability to recognize dockerfiles with extensions

[kmehant]

Description

Fixes #4566

Checklist:

• I am associating a language with a new file extension.

  • The new extension is used in hundreds of repositories on GitHub.com
    • Search results for each extension:
      • https://github.com/search?utf8=%E2%9C%93&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack
  • I have included a real-world usage sample for all extensions added in this PR:
    • Sample source(s):
      • [URL to each sample source, if applicable]
    • Sample license(s):
  • I have included a change to the heuristics to distinguish my language from others using the same extension.

• I am adding a new language.

  • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • Search results for each extension:
      • https://github.com/search?utf8=%E2%9C%93&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack
  • I have included a real-world usage sample for all extensions added in this PR:
    • Sample source(s):
      • [URL to each sample source, if applicable]
    • Sample license(s):
  • I have included a syntax highlighting grammar: https://github-lightshow.herokuapp.com/
  • I have updated the heuristics to distinguish my language from others using the same extension.

• I am fixing a misclassified language

  • I have included a new sample for the misclassified language:
    • Sample source(s):
      • [URL to each sample source, if applicable]
    • Sample license(s):
  • I have included a change to the heuristics to distinguish my language from others using the same extension.

• I am changing the source of a syntax highlighting grammar

  • Old: https://github-lightshow.herokuapp.com/
  • New: https://github-lightshow.herokuapp.com/

• I am updating a grammar submodule

• I am adding new or changing current functionality

  • I have added or updated the tests for the new or changed functionality.

• I am changing the color associated with a language

  • I have obtained agreement from the wider language community on this color change.
    • [URL to public discussion]
    • [Optional: URL to official branding guidelines for the language]

[kmehant]

@lildude, please review

[pchaigno]

Thanks for the report and pull request @kmehant!

Could you also add sample files in samples/Dockerfile/filenames/ for the new filenames you're adding? We prefer sample files to be from "real" application (not hello worlds, etc.) and under permissive license.

[pchaigno]

That's not going to work. You'll have to give the explicit name.

[Alhadis]

That's precisely the issue @kmehant has raised in #4566: Linguist has no way of identifying files based on a common prefix, only a suffix. Although that gives me an idea...

[pchaigno]

Is the lower-case D common? I've never encountered it before.

@lildude Any way we can search for that on GitHub.com? Maybe through Google BigQuery?

[lildude]

Not on GitHub itself as there's no case-sensitive search. I have no idea about BigQuery - never used it.

[lildude]

I have no idea about BigQuery - never used it.

I have now. 🎉

There are only 403 instances dockerfile in the BigQuery dataset according to this query:

SELECT repo_name, path
FROM `bigquery-public-data.github_repos.files`
WHERE path LIKE '%/dockerfile'
GROUP BY repo_name, path
LIMIT 5000

There are well over 5000 examples of Dockerfile though 😄

[pchaigno]

I have no idea about BigQuery - never used it.

I have now. 🎉

Wow! How did you do that so quickly? Is there a good tutorial for that? It would definitely improve our ability to asses in-the-wild usage.

[lildude]

I searched Google, found https://codelabs.developers.google.com/codelabs/bigquery-github/index.html?index=..%2F..index#0, signed into my work GCP account (I was already signed in, but could have used my personal account too) and put my terrible SQL skills to work 😁.

[lildude]

🤔 Other than the case of dockerfile which is new to me and probably discouraged as the documentation recommends Dockerfile, the rest of this PR sounds like an attempt to cater for personal preference as opposed to officially documented convention. An override is generally the best option for personal preference.

Additionally, there are waaaay too many variations of *[Dd]ockerfile* on GitHub.com to even reasonably attempt to cater for them by filename alone, assuming we could use wildcards or regex (we can't).

[kmehant]

Other than the case of dockerfile which is new to me and probably discouraged as the documentation recommends Dockerfile, the rest of this PR sounds like an attempt to cater for personal preference as opposed to officially documented convention. An override is generally the best option for personal preference.

Additionally, there are waaaay too many variations of *[Dd]ockerfile* on GitHub.com to even reasonably attempt to cater for them by filename alone, assuming we could use wildcards or regex (we can't).

How about the extensions such as Dockerfile.something or simply Dockerfile.* How about this. I am sure such are used widely

[lildude]

How about the extensions such as Dockerfile.something or simply Dockerfile.* How about this. I am sure such are used widely

They are, however you can't use wildcards or a regex for the filename strategy... only precise names can be used.

[kmehant]

How about the extensions such as Dockerfile.something or simply Dockerfile.* How about this. I am sure such are used widely

They are, however you can't use wildcards or a regex for the filename strategy... only precise names can be used.

Oh! I get it now then I think this is unresolvable as we can never have GitHub recognize Dockerfile.* files. Then let's close this PR

[pchaigno]

We can probably recognize the most common one.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

[stale]

This pull request has been automatically closed because it has not had activity in a long time. Please feel free to reopen it or create a new issue.