feat: Allow to manage github app secret manually #3703
Conversation
NadavOps
force-pushed
the
github_app_secret_data
branch
from
d041395 to
f6fe0b0
Compare
NadavOps
changed the title
|
This way we can create the parameter manually, and not need a way to pass the secret through env variable or other secret mechanism to avoid from saving it in the version control system. |
|
Thank you for taking the time to create a PR. There is with the current module no need to store the secrets on disk. You can inject them via environment variable. By settint TF_ENV_<variable_name> you can set the variables. Other optison are read variables passed in via the command line. Both options will avoid you from storing variables in VCS. In a pipeline you can use the secrets to pass the secrets into the deployment. Please can you explain what is not working with those options for you? |
|
Thank you for taking the time to review I also think its better to have more control over the parameter string name, I can change that in case you agree to the PR conceptually |
NadavOps
force-pushed
the
github_app_secret_data
branch
from
ea37517 to
477e527
Compare
|
Sorry for the delay. Please can you update the documentation with this option. I think it is good to add some more details to the AWS paramater section. Please can you format the terraform code? |
NadavOps
force-pushed
the
github_app_secret_data
branch
from
dd10241 to
dde0309
Compare
NadavOps
force-pushed
the
github_app_secret_data
branch
from
dde0309 to
f65021c
Compare
|
@npalm Hey, added explanation |
| @@ -7,13 +7,19 @@ resource "aws_ssm_parameter" "github_app_id" { | |||
| } | |||
|
|
|||
| resource "aws_ssm_parameter" "github_app_key_base64" { | |||
| count = var.github_app.key_base64 == null ? 0 : 1 | |||
There was a problem hiding this comment.
How did you test this by setting the variable explicit to null? In the app object?
There was a problem hiding this comment.
@NadavOps is this PR still relevant for you. How to test this?
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions. |
No description provided.