Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(view): File Icicle Summary의 util 함수 테스트 코드 작성 #769

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

lxxmnmn
Copy link
Contributor

@lxxmnmn lxxmnmn commented Oct 15, 2024

Related issue

Result

Work list

File Icicle Summary의 util 함수에 대한 테스트 코드를 작성했습니다.

  • getFileChangesMap
    • 데이터가 비어있을 경우 빈 객체를 반환하는지
    • 파일 경로와 각 파일별 insertion, deletion, commit의 합계를 반환하는지
  • getFileScoresMap
    • 데이터가 비어있을 경우 빈 객체를 반환하는지
    • 파일 경로와 1을 반환하는지
  • getFileChangesTree
    • 데이터가 비어있을 경우 루트 노드만 있는 객체를 반환하는지
    • 변경된 파일의 경로와 변경 내역을 트리 구조로 반환하는지

Discussion

@lxxmnmn lxxmnmn self-assigned this Oct 15, 2024
@lxxmnmn lxxmnmn requested review from a team as code owners October 15, 2024 08:38
@@ -0,0 +1,103 @@
import type { ClusterNode } from "types";

import { fakePrev } from "../../../../tests/fakeAsset";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fake data는 fakeAsset.ts를 활용했습니다.

Copy link
Contributor

@xxxjinn xxxjinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!🥰

Copy link
Contributor

@ytaek ytaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼼꼼하게 잘 작성된 것 같습니다!! LGTM!!

@lxxmnmn lxxmnmn merged commit a94f52e into githru:main Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants