Add golangci-lint config and CI step #55
Frostmanci.yaml
on: pull_request
Annotations
10 errors and 10 warnings
|
test:
pkg/agent/systemd/systemd.go#L82
error returned from external package is unwrapped: sig: func (*text/template.Template).Parse(text string) (*text/template.Template, error) (wrapcheck)
|
|
test:
pkg/agent/systemd/systemd.go#L88
error returned from external package is unwrapped: sig: func (*text/template.Template).Execute(wr io.Writer, data any) error (wrapcheck)
|
|
test:
pkg/util/netlinkutil/netlink.go#L26
error returned from external package is unwrapped: sig: func github.com/vishvananda/netlink.RouteGet(destination net.IP) ([]github.com/vishvananda/netlink.Route, error) (wrapcheck)
|
|
test:
pkg/util/iputil/ip.go#L36
error returned from external package is unwrapped: sig: func net.ParseCIDR(s string) (net.IP, *net.IPNet, error) (wrapcheck)
|
|
test:
pkg/agent/dozer/bcm/gnmi/client.go#L150
continue with no blank line before (nlreturn)
|
|
test:
pkg/agent/dozer/bcm/gnmi/client.go#L158
continue with no blank line before (nlreturn)
|
|
test:
pkg/agent/dozer/bcm/gnmi/client.go#L287
return with no blank line before (nlreturn)
|
|
test:
pkg/agent/dozer/bcm/gnmi/client.go#L106
error returned from external package is unwrapped: sig: func (*github.com/openconfig/gnmic/target.Target).Close() error (wrapcheck)
|
|
test:
pkg/agent/dozer/bcm/gnmi/client.go#L272
error returned from external package is unwrapped: sig: func github.com/openconfig/ygot/ytypes.Unmarshal(schema *github.com/openconfig/goyang/pkg/yang.Entry, parent interface{}, value interface{}, opts ...github.com/openconfig/ygot/ytypes.UnmarshalOpt) error (wrapcheck)
|
|
test:
pkg/agent/dozer/bcm/gnmi/client.go#L278
error returned from external package is unwrapped: sig: func github.com/openconfig/ygot/ytypes.Unmarshal(schema *github.com/openconfig/goyang/pkg/yang.Entry, parent interface{}, value interface{}, opts ...github.com/openconfig/ygot/ytypes.UnmarshalOpt) error (wrapcheck)
|
|
test:
pkg/agent/dozer/bcm/gnmi/password.go#L24
var-naming: don't use ALL_CAPS in Go names; use CamelCase (revive)
|
|
test:
pkg/agent/dozer/bcm/gnmi/password.go#L25
var-naming: don't use ALL_CAPS in Go names; use CamelCase (revive)
|
|
test:
pkg/agent/dozer/bcm/gnmi/password.go#L26
var-naming: don't use ALL_CAPS in Go names; use CamelCase (revive)
|
|
test:
pkg/agent/dozer/bcm/gnmi/client.go#L273
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
|
test:
pkg/dhcpd/dhcphandlers_test.go#L798
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
test:
pkg/dhcpd/dhcphandlers_test.go#L817
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
test:
pkg/wiring/data.go#L95
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
|
test:
test/framework/server.go#L25
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
test:
test/framework/server.go#L30
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
test:
test/framework/framework.go#L56
empty-block: this block is empty, you can remove it (revive)
|