Add golangci-lint config and CI step #50
Frostmanci.yaml
on: pull_request
Annotations
10 errors and 10 warnings
|
test:
pkg/dhcpd/dhcphandlers_test.go#L520
Error return value of `pool.Allocate` is not checked (errcheck)
|
|
test:
pkg/dhcpd/dhcphandlers_test.go#L521
Error return value of `pool.Allocate` is not checked (errcheck)
|
|
test:
pkg/dhcpd/dhcphandlers_test.go#L522
Error return value of `pool.Allocate` is not checked (errcheck)
|
|
test:
pkg/agent/dozer/bcm/spec_route_maps.go#L205
Error return value of `statements.Append` is not checked (errcheck)
|
|
test:
api/wiring/v1alpha2/connection_types.go#L366
string `<invalid>` has 8 occurrences, make it a constant (goconst)
|
|
test:
api/vpc/v1alpha2/external_types.go#L97
string `default` has 7 occurrences, make it a constant (goconst)
|
|
test:
pkg/dhcpd/dhcphandlers_test.go#L300
string `VrfV16` has 4 occurrences, make it a constant (goconst)
|
|
test:
pkg/dhcpd/dhcphandlers_test.go#L215
string `VrfV15` has 3 occurrences, make it a constant (goconst)
|
|
test:
pkg/dhcpd/dhcphandlers_test.go#L60
string `Vlan2000` has 14 occurrences, make it a constant (goconst)
|
|
test:
pkg/hhfctl/connection.go#L49
string `custom-columns=` has 3 occurrences, make it a constant (goconst)
|
|
test:
api/meta/types.go#L241
error-strings: error strings should not be capitalized or end with punctuation or a newline (revive)
|
|
test:
api/meta/types.go#L145
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
|
test:
api/meta/types.go#L155
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
|
test:
api/wiring/v1alpha2/rack_types.go#L91
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
test:
api/wiring/v1alpha2/server_types.go#L120
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
test:
api/wiring/v1alpha2/switchgroup_types.go#L82
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
test:
api/wiring/v1alpha2/connection_types.go#L427
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|
|
test:
api/wiring/v1alpha2/server_types.go#L108
receiver-naming: receiver name server should be consistent with previous receiver name s for Server (revive)
|
|
test:
api/wiring/v1alpha2/meta.go#L27
var-naming: don't use ALL_CAPS in Go names; use CamelCase (revive)
|
|
test:
api/wiring/v1alpha2/connection_types.go#L36
var-naming: don't use ALL_CAPS in Go names; use CamelCase (revive)
|