Beta 1 draft #40
Merged
Beta 1 draft #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbojangles3
requested review from
Frostman,
sergeymatov,
amitlimaye,
sonoble and
thedvorkin
as code owners
|
🚀 Deployed on https://preview-40--hedgehog-docs.netlify.app |
qmonnet
requested changes
Oct 22, 2024
Co-authored-by: Quentin Monnet <[email protected]>
amitlimaye
reviewed
Oct 23, 2024
Co-authored-by: Quentin Monnet <[email protected]>
Co-authored-by: Quentin Monnet <[email protected]>
Co-authored-by: Quentin Monnet <[email protected]>
Thank for the thorough review! Co-authored-by: Quentin Monnet <[email protected]>
mrbojangles3
commented
Oct 24, 2024
Frostman
reviewed
Oct 24, 2024
| @@ -1870,7 +1868,6 @@ _Appears in:_ | |||
| | `label` _string_ | Label defines the physical port label you can see on the actual switch | | | | |||
| | `group` _string_ | If port isn't directly manageable, group defines the group it belongs to, exclusive with profile | | | | |||
| | `profile` _string_ | If port is directly configurable, profile defines the profile it belongs to, exclusive with group | | | | |||
There was a problem hiding this comment.
It's generated file and management flag on port is unrelated to management connections
Frostman
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.