Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add workflow to ensure Rust code is consistently formatted #97

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented Nov 18, 2024

Rather than leaving formatting decisions up to every developer, enforce them consistently with rustfmt. To do so, add a workflow that checks that the code has been properly formatted, with "cargo fmt --check".

The objective of creating this workflow early, while there are few formatting reports to address, is to avoid having a huge commit at a later time to fix formatting throughout the repository.

Reboot of #95

Format files consistently using rustfmt.

Signed-off-by: Quentin Monnet <[email protected]>
Rather than leaving formatting decisions up to every developer, enforce
them consistently with rustfmt. To do so, add a workflow that checks
that the code has been properly formatted, with "cargo fmt --check".

Signed-off-by: Quentin Monnet <[email protected]>
@qmonnet qmonnet added the ci Continuous Integration label Nov 18, 2024
@qmonnet qmonnet requested a review from a team as a code owner November 18, 2024 18:05
@qmonnet qmonnet requested review from daniel-noland and removed request for a team November 18, 2024 18:05
Copy link
Collaborator

@daniel-noland daniel-noland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This is an improvement for sure

@daniel-noland daniel-noland merged commit afbae1a into main Nov 20, 2024
16 checks passed
@daniel-noland daniel-noland deleted the pr/qmonnet/rustfmt branch November 20, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants