Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Build each commit individually #96

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented Nov 18, 2024

In dev.yml workflow, instead of building only the commit at the top of
a Pull Request branch, run a Cargo build for each commit in the Pull
Request. The objective is to make sure that each commit can build in a
standalone fashion, and to limit the risk of breaking bisects.

Notes:

  • We do not check whether commit actually changes source code files.
  • We do not build all commits for each supported configuration.
  • We do not run tests for all commits.

Reboot of #93

In dev.yml workflow, instead of building only the commit at the top of
a Pull Request branch, run a Cargo build for each commit in the Pull
Request. The objective is to make sure that each commit can build in a
standalone fashion, and to limit the risk of breaking bisects.

Notes:

  - We do not check whether commit actually changes source code files.
  - We do not build all commits for each supported configuration.
  - We do not run tests for all commits.

Signed-off-by: Quentin Monnet <[email protected]>
@qmonnet qmonnet added the ci Continuous Integration label Nov 18, 2024
@qmonnet qmonnet requested a review from a team as a code owner November 18, 2024 18:04
@qmonnet qmonnet requested review from daniel-noland and removed request for a team November 18, 2024 18:04
Copy link
Collaborator

@daniel-noland daniel-noland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This is great progress

@daniel-noland daniel-noland merged commit 58e6fe7 into main Nov 20, 2024
13 checks passed
@daniel-noland daniel-noland deleted the pr/qmonnet/ci-build-all-commits branch November 20, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants