Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: Add basic CODEOWNERS file #78

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented Nov 12, 2024

Make everything owned by a single team. The idea is to be able to have auto-assignment for reviews on Pull Requests. We can use finer-grained ownership later if necessary.

Make everything owned by a single team. The idea is to be able to have
auto-assignment for reviews on Pull Requests. We can use finer-grained
ownership later if necessary.

Signed-off-by: Quentin Monnet <[email protected]>
@qmonnet qmonnet added the ci Continuous Integration label Nov 12, 2024
@qmonnet
Copy link
Member Author

qmonnet commented Nov 12, 2024

I created team @dataplane-reviewers with Daniel and me in it (for now), and given write access to this repository. Once the CODEOWNERS file is merged, new pull request should automatically ask for a review from that team.

In the team's settings, I have also enabled auto-assignment for reviews, meaning that GitHub should automatically replace review requests for the team with a request to one individual from the team (using a load-balancing algorithm to balance the review load between the different team members).

This should mean we won't have to click buttons anymore to ask for reviews (unless we need a specific reviewer), and PRs won't get blocked because we forgot to ask for a review.

@qmonnet qmonnet enabled auto-merge (rebase) November 12, 2024 14:56
Copy link
Collaborator

@daniel-noland daniel-noland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me :)

@qmonnet qmonnet merged commit 76cf7df into main Nov 12, 2024
11 checks passed
@qmonnet qmonnet deleted the pr/qmonnet/codeowners branch November 12, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants