ci: Run dev.yml, sterile.yml workflows on pull_request #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
qmonnet
commented
Nov 12, 2024
qmonnet
commented
- ci: Harmonise workflow description files
- ci: Run dev.yml, sterile.yml workflows on pull_request
qmonnet
force-pushed
the
pr/qmonnet/ci-pull-request
branch
2 times, most recently
from
3a80737 to
be39fcc
Compare
Make workflow description files more consistent:
- Add a comment to describe the workflow at the top of the file, for
workflows that didn't have one yet
- Use consistent options for tmate options on "workflow_dispatch"
- Use a consistent order for trigger events ("on:")
- Use a consistent order for workflow permissions
- Use a blank line between top-level sections
- Remove trailing blank lines at the end of files
The objective is to make it easier to compare the different workflow
files visually.
No functional change.
Signed-off-by: Quentin Monnet <[email protected]>
Rather than running the dev.yml and sterile.yml workflows everytime developers push to any branch, run them for "pull_target" events. This makes it easier to integrate with Pull Requests (for example for setting required tests) and avoids running unnecessary workflows when branches are pushed with no immediate intention to open a PR. Keep running on "push", but for "main" branch only, to run the workflows on the new "main" when PRs get merged. Signed-off-by: Quentin Monnet <[email protected]>
qmonnet
force-pushed
the
pr/qmonnet/ci-pull-request
branch
from
be39fcc to
d9ec43b
Compare
daniel-noland
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.