Fixup .gitignore #67
Merged
Fixup .gitignore #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-noland
force-pushed
the
minor-cleanup
branch
from
e76a2ae to
9597d49
Compare
|
CI failure fixed in #68 |
daniel-noland
force-pushed
the
minor-cleanup
branch
from
9597d49 to
ea8ed6c
Compare
|
CI failure over! |
daniel-noland
force-pushed
the
minor-cleanup
branch
from
ea8ed6c to
b432d52
Compare
|
don't merge till #67 lands (or we have to mess with CI rebase again) |
daniel-noland
force-pushed
the
minor-cleanup
branch
from
b432d52 to
ff5b6a3
Compare
qmonnet
reviewed
Nov 11, 2024
.gitignore
Outdated
Comment on lines
3
to
4
| /result* | ||
| /target/** |
There was a problem hiding this comment.
We can also remove these two rules, these directories are covered by the two rules above.
There was a problem hiding this comment.
Yup. That's what I get for having autogenerated .gitignore
From man gitignore:
A leading "**" followed by a slash means match in all directories.
For example, "**/foo" matches file or directory "foo" anywhere, the
same as pattern "foo".
In other words, we don't need "/target/**" in the .gitignore if we
already have "**/target/**". Same applies to "/result*". Let's remove
the redundant rules.
Also sort the file alphabetically (as per Vim's ":%s").
Signed-off-by: Quentin Monnet <[email protected]>
|
I pushed a commit on top of your branch. |
qmonnet
approved these changes
Nov 11, 2024
We're good now that we no longer require the base branch to be up-to-date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.