justfile: Truncate tag names, everywhere necessary #66
Conversation
qmonnet
commented
Nov 9, 2024
qmonnet
commented
- Revert "justfile: Truncate container tag string if too long"
- justfile: Truncate container tag string if too long (2nd attempt)
|
Not good yet |
qmonnet
force-pushed
the
pr/qmonnet/cant-believe-i-am-using-such-a-long-long-branch-name-but-gotta-try-to-overflow-container-tag-name-limit-yes-we-do
branch
3 times, most recently
from
e37c2b9 to
54311ab
Compare
qmonnet
force-pushed
the
pr/qmonnet/cant-believe-i-am-using-such-a-long-long-branch-name-but-gotta-try-to-overflow-container-tag-name-limit-yes-we-do
branch
from
54311ab to
1246934
Compare
|
All tests passed this time! 🎉 |
This reverts commit 0874727. Turns out this commit missed a lot of occurrences where tag can be too long, let's find a more generic truncate function to solve the issue. Signed-off-by: Quentin Monnet <[email protected]>
Containers' tags can't be longer than 128 characters. Sometimes CI generates tags that are longer than this (thanks Dependabot for the extra-long branch names). Make sure we don't break docker builds by having bash truncate the string if necessary - everywhere we need it. Fixes: b88ec42 ("Build system") Signed-off-by: Quentin Monnet <[email protected]>
daniel-noland
force-pushed
the
pr/qmonnet/cant-believe-i-am-using-such-a-long-long-branch-name-but-gotta-try-to-overflow-container-tag-name-limit-yes-we-do
branch
from
1246934 to
728171e
Compare
|
Side note, your preference is to always rebase on the current |
As long as we have
then I'm good. I love bisection methods and non-linear history and commits which don't build ruin it 🤷♀️ Really, we should open source this stuff and then we can just use the merge queue method |
We don't currently build each commit independently, do we? |
Not yet no. It is something I would like to get in place tho. I'm less stressed about it very early on in the project like this because it is unlikely we will care about bisection before we implement any real features. |
daniel-noland
deleted the
pr/qmonnet/cant-believe-i-am-using-such-a-long-long-branch-name-but-gotta-try-to-overflow-container-tag-name-limit-yes-we-do
branch
