Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup clippy #55

Merged
merged 1 commit into from
Nov 4, 2024
Merged

fixup clippy #55

merged 1 commit into from
Nov 4, 2024

Conversation

daniel-noland
Copy link
Collaborator

this should fix the clippy build.

Basically, I didn't realize that SYSROOT was a special environment variable for clippy and it broke everything :)

@daniel-noland daniel-noland requested a review from qmonnet November 4, 2024 18:43
@daniel-noland daniel-noland force-pushed the fix-clippy branch 9 times, most recently from 55476c7 to 43c9967 Compare November 4, 2024 22:46
@daniel-noland daniel-noland marked this pull request as ready for review November 4, 2024 22:58
@daniel-noland daniel-noland merged commit 1793bf9 into real-readme Nov 4, 2024
8 checks passed
@daniel-noland daniel-noland deleted the fix-clippy branch November 4, 2024 22:58
@qmonnet
Copy link
Member

qmonnet commented Nov 5, 2024

@daniel-noland I note you commented out a bunch of steps in .github/workflows/check-developer-experience.yml in this PR, is that intentional? (I'm just checking. I haven't looked into the details.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants