planning docs #100
planning docs #100
Conversation
|
It builds but the preview is broken for me, the link to most pages are invalid |
daniel-noland
force-pushed
the
planning
branch
29 times, most recently
from
0fec5c9 to
ccfce87
Compare
daniel-noland
force-pushed
the
planning
branch
3 times, most recently
from
c6b0a25 to
5b4fa3d
Compare
daniel-noland
force-pushed
the
planning
branch
from
5b4fa3d to
f0398b2
Compare
dpdk-sys 1. no longer provides nightly builds for sterile 2. made some adjustments to the wrte wrapper which required some minor renaming. 3. changed the name of the docker images This PR accounts for this
The javascript had gotten a little messy (frankly it still is), but it is far less chaotic now. Significant chunks of commented code have been removed.
daniel-noland
force-pushed
the
planning
branch
from
f0398b2 to
18c412a
Compare
The svg elements are being embedded with directly set width and height values. This overrides the CSS style they should be getting, so just move the assigned setting to style attributes.
No need to carry around .js files for mermaid.
This was used in another project and somehow made it in to this one. Remove.
Expand and re-organize docs to add in design work by the whole team.
daniel-noland
force-pushed
the
planning
branch
from
18c412a to
e18667f
Compare
This should be resolved now. I appreciate the attention to detail. |
| * [@Fredi-raspall] | ||
| * coordinate with: [@daniel-noland] | ||
|
|
||
| {{#include ../../links.md}} |
There was a problem hiding this comment.
I know that with Sphinx, there's an option to include this sort of stuff automatically in the footer of all pages. I don't know if mdBook (on a quick look, I couldn't find an equivalent option). Anyway, doesn't matter much.
There was a problem hiding this comment.
Yeah, I could make it work. I just didn't try that hard for such a small thing
|
Looks all good to me, you can merge it or wait for more reviews if your prefer |
Unfortunately this commit required changes to dpdk-sys to build. As a result, we lost nightly-sterile builds in a commit where I normally would not have messed with that.