back to full?

githedgehog · Nov 5, 2024 · 2b6a1fa · 2b6a1fa
1 parent 180d295
commit 2b6a1fa
Show file tree

Hide file tree

Showing 4 changed files with 92 additions and 92 deletions.
diff --git a/.github/workflows/build-and-deploy-docs.yml b/.github/workflows/build-and-deploy-docs.yml
@@ -12,7 +12,7 @@ on:
       - "main"
 
 concurrency:
-  group: "${{ github.workflow }}-${{ github.event.pull_request.number || github.event.after }}"
+  group: "${{ github.workflow }}:${{ github.event.pull_request.number || github.event.after }}"
   cancel-in-progress: true
 
 permissions:

diff --git a/.github/workflows/check-developer-experience.yml b/.github/workflows/check-developer-experience.yml
@@ -19,7 +19,7 @@ on:
   push: {}
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
+  group: ${{ github.workflow }}:${{ github.ref }}
   cancel-in-progress: true
 
 permissions:
@@ -96,23 +96,23 @@ jobs:
           just debug=true rust=${{matrix.rust.toolchain}} profile=dev target=x86_64-unknown-linux-musl report
         continue-on-error: ${{ matrix.rust.optional }}
 
-      # - run: just cargo +${{matrix.rust.toolchain}} build --locked --profile=release --target=x86_64-unknown-linux-gnu
-      #   continue-on-error: ${{ matrix.rust.optional }}
-      # - name: "tests: rust ${{ matrix.rust.toolchain }} profile=release target=x86_64-unknown-linux-gnu"
-      #   run: |
-      #     export GITHUB_STEP_SUMMARY
-      #     just debug=true rust=${{matrix.rust.toolchain}} profile=release target=x86_64-unknown-linux-gnu test
-      #     just debug=true rust=${{matrix.rust.toolchain}} profile=release target=x86_64-unknown-linux-gnu report
-      #   continue-on-error: ${{ matrix.rust.optional }}
+      - run: just cargo +${{matrix.rust.toolchain}} build --locked --profile=release --target=x86_64-unknown-linux-gnu
+        continue-on-error: ${{ matrix.rust.optional }}
+      - name: "tests: rust ${{ matrix.rust.toolchain }} profile=release target=x86_64-unknown-linux-gnu"
+        run: |
+          export GITHUB_STEP_SUMMARY
+          just debug=true rust=${{matrix.rust.toolchain}} profile=release target=x86_64-unknown-linux-gnu test
+          just debug=true rust=${{matrix.rust.toolchain}} profile=release target=x86_64-unknown-linux-gnu report
+        continue-on-error: ${{ matrix.rust.optional }}
 
-      # - run: just cargo +${{matrix.rust.toolchain}} build --locked --profile=release --target=x86_64-unknown-linux-musl
-      #   continue-on-error: ${{ matrix.rust.optional }}
-      # - name: "tests: rust ${{ matrix.rust.toolchain }} profile=release target=x86_64-unknown-linux-musl"
-      #   run: |
-      #     export GITHUB_STEP_SUMMARY
-      #     just debug=true rust=${{matrix.rust.toolchain}} profile=release target=x86_64-unknown-linux-musl test
-      #     just debug=true rust=${{matrix.rust.toolchain}} profile=release target=x86_64-unknown-linux-musl report
-      #   continue-on-error: ${{ matrix.rust.optional }}
+      - run: just cargo +${{matrix.rust.toolchain}} build --locked --profile=release --target=x86_64-unknown-linux-musl
+        continue-on-error: ${{ matrix.rust.optional }}
+      - name: "tests: rust ${{ matrix.rust.toolchain }} profile=release target=x86_64-unknown-linux-musl"
+        run: |
+          export GITHUB_STEP_SUMMARY
+          just debug=true rust=${{matrix.rust.toolchain}} profile=release target=x86_64-unknown-linux-musl test
+          just debug=true rust=${{matrix.rust.toolchain}} profile=release target=x86_64-unknown-linux-musl report
+        continue-on-error: ${{ matrix.rust.optional }}
 
       - uses: actions/upload-artifact@v4
         if: ${{ always() }}

diff --git a/.github/workflows/sterile-build-and-test.yml b/.github/workflows/sterile-build-and-test.yml
@@ -13,28 +13,21 @@ on:
         default: false
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
+  group: ${{ github.workflow }}:${{ github.ref }}
   cancel-in-progress: true
 
-env:
-  just: 1.36.0
-
-permissions:
-  contents: write
-  packages: write
-  id-token: write
-
 jobs:
   test:
+    permissions:
+      packages: read
+      id-token: write
     runs-on: lab
     strategy:
       fail-fast: false
       matrix:
-        dpdk_sys:
-          - main
         rust:
           - stable
-          # - nightly
+          - nightly
     steps:
       - name: login to ghcr.io
         uses: docker/login-action@v3
@@ -43,88 +36,89 @@ jobs:
           username: "${{ github.actor }}"
           password: "${{ secrets.GITHUB_TOKEN }}"
 
-      - uses: cargo-bins/cargo-binstall@main
+      - name: install rust
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: ${{ matrix.rust }}
+          targets: x86_64-unknown-linux-gnu
 
+      - uses: cargo-bins/cargo-binstall@main
       - name: install just
         run: cargo binstall --no-confirm just
 
-      - name: install openssl and libssl-dev (needed for markdown-test-report)
-        if: ${{ always() }}
-        run: |
-          sudo apt-get update
-          sudo apt-get --yes --no-install-recommends install \
-            colorized-logs \
-            libssl-dev \
-            openssl \
-            pkg-config
-
-      - name: install markdown-test-report
-        if: ${{ always() }}
-        run: cargo binstall --no-confirm markdown-test-report
-
       - name: Checkout
         uses: actions/checkout@v4
 
       - name: dev/gnu sterile test
+        if: ${{ always() }}
         run: |
           export GITHUB_STEP_SUMMARY
           just rust="${{matrix.rust}}" profile=dev target=x86_64-unknown-linux-gnu sterile test
           mkdir dev.gnu
           cp -a ./target/nextest dev.gnu
+
+      - name: release/gnu sterile test
+        if: ${{ always() }}
+        run: |
+          export GITHUB_STEP_SUMMARY
+          just rust="${{matrix.rust}}" profile=release target=x86_64-unknown-linux-gnu sterile test
+          mkdir release.gnu
+          cp -a ./target/nextest release.gnu
+
       - name: dev/musl sterile test
+        if: ${{ always() }}
         run: |
           export GITHUB_STEP_SUMMARY
           just rust="${{matrix.rust}}" profile=dev target=x86_64-unknown-linux-musl sterile test
           mkdir dev.musl
           cp -a ./target/nextest dev.musl
-      #- name: release/gnu sterile test
-      #  run: |
-      #    export GITHUB_STEP_SUMMARY
-      #    just rust="${{matrix.rust}}" profile=release target=x86_64-unknown-linux-gnu sterile test
-      #    mkdir release.gnu
-      #    cp -a ./target/nextest release.gnu
-      #- name: release/musl sterile test
-      #  run: |
-      #    export GITHUB_STEP_SUMMARY
-      #    just rust="${{matrix.rust}}" profile=release target=x86_64-unknown-linux-musl sterile test
-      #    mkdir release.musl
-      #    cp -a ./target/nextest release.musl
-
-      # NOTE: we don't even install rust till the sterile tests are done (lowers contamination risk)
-      - name: install rust
-        uses: dtolnay/rust-toolchain@stable
+
+      - name: release/musl sterile test
         if: ${{ always() }}
-        with:
-          toolchain: ${{ matrix.rust }}
-          targets: x86_64-unknown-linux-gnu,x86_64-unknown-linux-musl
+        run: |
+          export GITHUB_STEP_SUMMARY
+          just rust="${{matrix.rust}}" profile=release target=x86_64-unknown-linux-musl sterile test
+          mkdir release.musl
+          cp -a ./target/nextest release.musl
+
+      - name: install markdown-test-report
+        if: ${{ always() }}
+        run: |
+          sudo apt-get update
+          sudo apt-get --yes --no-install-recommends install \
+            colorized-logs \
+            libssl-dev \
+            openssl \
+            pkg-config
+          cargo binstall --no-confirm markdown-test-report
 
       - name: dev/gnu report
+        if: ${{ always() }}
         run: |
           export GITHUB_STEP_SUMMARY
           export CARGO_TARGET_DIR=dev.gnu
           just rust="${{matrix.rust}}" profile=dev target=x86_64-unknown-linux-gnu report
-        if: ${{ always() }}
 
       - name: dev/musl report
+        if: ${{ always() }}
         run: |
           export GITHUB_STEP_SUMMARY
           export CARGO_TARGET_DIR=dev.musl
           just rust="${{matrix.rust}}" profile=dev target=x86_64-unknown-linux-musl report
-        if: ${{ always() }}
 
-      #- name: release/gnu report
-      #  run: |
-      #    export GITHUB_STEP_SUMMARY
-      #    export CARGO_TARGET_DIR=release.gnu
-      #    just rust="${{matrix.rust}}" profile=release target=x86_64-unknown-linux-gnu report
-      #  if: ${{ always() }}
+      - name: release/gnu report
+        if: ${{ always() }}
+        run: |
+          export GITHUB_STEP_SUMMARY
+          export CARGO_TARGET_DIR=release.gnu
+          just rust="${{matrix.rust}}" profile=release target=x86_64-unknown-linux-gnu report
 
-      #- name: release/musl report
-      #  run: |
-      #    export GITHUB_STEP_SUMMARY
-      #    export CARGO_TARGET_DIR=release.musl
-      #    just rust="${{matrix.rust}}" profile=release target=x86_64-unknown-linux-musl report
-      #  if: ${{ always() }}
+      - name: release/musl report
+        if: ${{ always() }}
+        run: |
+          export GITHUB_STEP_SUMMARY
+          export CARGO_TARGET_DIR=release.musl
+          just rust="${{matrix.rust}}" profile=release target=x86_64-unknown-linux-musl report
 
       - uses: actions/upload-artifact@v4
         if: ${{ always() }}
@@ -133,33 +127,41 @@ jobs:
           path: target/nextest
 
       - name: Setup tmate session for debug
-        if: ${{ failure() }}
+        if: ${{ failure() && github.event_name == 'workflow_dispatch' && inputs.debug_enabled }}
         uses: mxschmitt/action-tmate@v3
-        timeout-minutes: 30
+        timeout-minutes: 60
         with:
           limit-access-to-actor: true
 
   push:
+    permissions:
+      packages: write
+      id-token: write
     runs-on: lab
     strategy:
       fail-fast: false
       matrix:
-        dpdk_sys:
-          - main
         rust:
           - stable
-          # - nightly
+          - nightly
     steps:
       - name: login to ghcr.io
         uses: docker/login-action@v3
         with:
           registry: ghcr.io
           username: "${{ github.actor }}"
           password: "${{ secrets.GITHUB_TOKEN }}"
-      - name: install just
-        uses: extractions/setup-just@v2
+
+      - name: install rust
+        uses: dtolnay/rust-toolchain@stable
         with:
-          just-version: ${{env.just}}
+          toolchain: ${{ matrix.rust }}
+          targets: x86_64-unknown-linux-gnu
+
+      - uses: cargo-bins/cargo-binstall@main
+      - name: install just
+        run: cargo binstall --no-confirm just
+
       - name: Checkout
         uses: actions/checkout@v4
 
@@ -169,14 +171,12 @@ jobs:
           toolchain: ${{ matrix.rust }}
           targets: x86_64-unknown-linux-gnu
       - uses: cargo-bins/cargo-binstall@main
-      - name: install cargo-deny
-        run: cargo binstall --no-confirm cargo-deny
-      # we want to avoid pushing any container which fails our carg-deny checks
+      - run: cargo binstall --no-confirm cargo-deny
       - run: just cargo deny check
       - run: just rust="${{matrix.rust}}" profile=debug target=x86_64-unknown-linux-gnu push-container
-      # - run: just rust="${{matrix.rust}}" profile=release target=x86_64-unknown-linux-gnu push-container
+      - run: just rust="${{matrix.rust}}" profile=release target=x86_64-unknown-linux-gnu push-container
       - run: just rust="${{matrix.rust}}" profile=debug target=x86_64-unknown-linux-musl push-container
-      # - run: just rust="${{matrix.rust}}" profile=release target=x86_64-unknown-linux-musl push-container
+      - run: just rust="${{matrix.rust}}" profile=release target=x86_64-unknown-linux-musl push-container
 
       - name: Setup tmate session for debug
         if: ${{ failure() && github.event_name == 'workflow_dispatch' && inputs.debug_enabled }}

diff --git a/.github/workflows/update-versions.yml b/.github/workflows/update-versions.yml
@@ -24,7 +24,7 @@ on:
     - cron: '18 3 * * *'
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
+  group: ${{ github.workflow }}:${{ github.ref }}
   cancel-in-progress: true
 
 permissions: