Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reposition darwin traffic-lights in title bar #6102

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: reposition darwin traffic-lights in title bar #6102

wants to merge 6 commits into from

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Jan 28, 2025 •
edited
Loading

🧢 Changes

☕️ Reasoning

@vercel Vercel
Copy link

vercel bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:39am
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 10:39am

@github-actions github-actions bot added the rust Pull requests that update Rust code label Jan 28, 2025
@ndom91 ndom91 force-pushed the feat-traffic-light-positioner branch from fc8dc4c to 224c84b Compare January 28, 2025 16:19
@ndom91 ndom91 force-pushed the feat-traffic-light-positioner branch from 224c84b to af3f98a Compare January 28, 2025 16:24
@ndom91 ndom91 force-pushed the feat-traffic-light-positioner branch from af3f98a to f36fcb6 Compare January 28, 2025 16:30
@ndom91 ndom91 force-pushed the feat-traffic-light-positioner branch from f36fcb6 to af51129 Compare January 28, 2025 19:15
@Byron
Copy link
Collaborator

Byron commented Jan 29, 2025

With the fix I pushed it compiles and does seem to have an effect.

Screenshot 2025-01-29 at 09 17 39

@Byron
Copy link
Collaborator

Byron commented Jan 29, 2025

CI still fails with terrible build errors on Linux it seems, an issue that isn't reproducible on MacOS.

Does the following reproduce the issue locally on Linux?

cargo check --workspace --all-targets

@ndom91
Copy link
Contributor Author

ndom91 commented Jan 29, 2025

CI still fails with terrible build errors on Linux it seems, an issue that isn't reproducible on MacOS.

Does the following reproduce the issue locally on Linux?

cargo check --workspace --all-targets

Yeah so locally here on my linux box I get the same error messages as in CI 😭

image

@ndom91 ndom91 force-pushed the feat-traffic-light-positioner branch from 01f08fd to e186ffb Compare January 29, 2025 12:24
@PavelLaptev PavelLaptev force-pushed the feat-traffic-light-positioner branch from e186ffb to 448b022 Compare January 29, 2025 12:41
@ndom91 ndom91 force-pushed the feat-traffic-light-positioner branch from cbc2d2d to 9a4e24b Compare January 30, 2025 10:20
@ndom91 ndom91 marked this pull request as ready for review January 30, 2025 10:37
@ndom91
Copy link
Contributor Author

ndom91 commented Jan 30, 2025

Thanks for the Cargo.toml fixes @Byron. @PavelLaptev feel free to merge this whenever you're happy with the positioning 👍

@ndom91 ndom91 force-pushed the feat-traffic-light-positioner branch from 9a4e24b to 670e17c Compare January 30, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@gitbutler/desktop rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndom91 @Byron @PavelLaptev