feat: allow ContextMenu.svelte to open on all sides
#6080
Merged
+103
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ndom91
force-pushed
the
feat-contextMenu-add-left-right-side-options
branch
from
a9aeef9 to
a255f33
Compare
ndom91
force-pushed
the
feat-contextMenu-add-left-right-side-options
branch
from
c9e1b17 to
005e7ea
Compare
ndom91
force-pushed
the
feat-contextMenu-add-left-right-side-options
branch
from
005e7ea to
8e6710b
Compare
ndom91
force-pushed
the
feat-contextMenu-add-left-right-side-options
branch
from
a8a94ad to
17e88ed
Compare
ndom91
force-pushed
the
feat-contextMenu-add-left-right-side-options
branch
from
7a9f40c to
65ea43c
Compare
ndom91
changed the title
ContextMenu.svelte to open on all sides
Caleb-T-Owens
approved these changes
Jan 28, 2025
auto-merge was automatically disabled
January 28, 2025 16:11
Rebase failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧢 Changes
sideprop ('left' | 'right' | 'top' | 'bottom') toContextMenu.svelteSidebar Btn ContextMenu is currently set to
right+bottomalignment in this PR.The design has it aligned
right+topso it grows down from the top edge of the trigger button, but we have too many items in the menu atm so it would exit the viewport at the bottom and then be autocorrected to another orientation.Another follow-up PR to this one is to enable multi-level context menus like in the design, which will fix this issue:
☕️ Reasoning