Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Signing #6069

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Fix Signing #6069

merged 3 commits into from
Jan 24, 2025
+78 −57

Conversation

Byron
Copy link
Collaborator

@Byron Byron commented Jan 23, 2025 •
edited
Loading

Tasks

  • Debugging tool for environment variables
  • path-quoting for the command itself
  • switch to gitoxide on main
  • test it for real once!

@vercel Vercel
Copy link

vercel bot commented Jan 23, 2025

@Byron is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added rust Pull requests that update Rust code @gitbutler/desktop labels Jan 23, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 9:03am

@Byron Byron mentioned this pull request Jan 23, 2025
Merged
@Caleb-T-Owens
Copy link
Contributor

@Byron if the command has already been quoted, should we strip them out? For a short while the advice on discord and GH was to add them, but now they could be problematic?

@Byron
Copy link
Collaborator Author

Byron commented Jan 24, 2025

The issue was that the command is now run as shell-command on Windows, which also means commands would need to be quoted to handle paths with spaces like …/Program Files/… correctly.
It's quite sad I didn't see that coming as well.

@Byron Byron marked this pull request as ready for review January 24, 2025 08:40
@Byron Byron enabled auto-merge January 24, 2025 09:00
@Byron Byron merged commit 8da088e into gitbutlerapp:master Jan 24, 2025
22 of 23 checks passed
@Byron Byron deleted the signing branch January 24, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlvi krlvi krlvi approved these changes

Assignees
No one assigned
Labels
@gitbutler/desktop rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSH: Unable to find program
3 participants
@Byron @Caleb-T-Owens @krlvi