Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify tree_change_diffs to handle a single change #6043

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

krlvi
Copy link
Member

@krlvi krlvi commented Jan 22, 2025

There is no material cost to making many requests and enforcing that we do the fetching one at a time will allow for better error handling and in general having the UI be more lazy in loading data

There is no material cost to making many requests and enforcing that we do the fetching one at a time will allow for better error handling and in general having the UI be more lazy in loading data
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 10:06am
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 10:06am

@github-actions github-actions bot added rust Pull requests that update Rust code @gitbutler/desktop labels Jan 22, 2025
@krlvi krlvi merged commit e4ce232 into master Jan 22, 2025
23 checks passed
@krlvi krlvi deleted the update-tree-change-diffs-function branch January 22, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@gitbutler/desktop rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant