Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3 stack branches endpoint WIP #5984

Merged
merged 4 commits into from
Jan 22, 2025
Merged

v3 stack branches endpoint WIP #5984

merged 4 commits into from
Jan 22, 2025

Conversation

krlvi
Copy link
Member

@krlvi krlvi commented Jan 17, 2025 •
edited
Loading

This is a port of "list_virtual_branches" but operating on a single stack at a time and without dependency to the gitbutler-branch-actions code.

The key constraint here is to keep this compatible with the stacks implementation.

Tasks:

  • Port over the implementation
  • CLI integration
  • Tauri API
  • Tests

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 4:36pm
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 4:36pm

@github-actions github-actions bot added the rust Pull requests that update Rust code label Jan 17, 2025
@krlvi krlvi requested a review from Byron January 20, 2025 11:48
Byron
Byron reviewed Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some intermediate comments, will continue in a moment.

crates/but-workspace/src/integrated.rs Outdated Show resolved Hide resolved
crates/but-workspace/src/lib.rs Outdated Show resolved Hide resolved
crates/but-workspace/src/lib.rs Show resolved Hide resolved
crates/but-workspace/src/lib.rs Show resolved Hide resolved
Byron
Byron reviewed Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having me take an early look! I really like the docs, it's exactly what we need to keep the APIs to the point digest the existing business logic into "what it wants to be".

crates/but-workspace/src/lib.rs Outdated Show resolved Hide resolved
crates/but-workspace/src/lib.rs Outdated Show resolved Hide resolved
crates/but-workspace/src/lib.rs Outdated Show resolved Hide resolved
crates/but-workspace/src/lib.rs Outdated Show resolved Hide resolved
crates/but-workspace/src/lib.rs Show resolved Hide resolved
crates/but-workspace/src/lib.rs Show resolved Hide resolved
crates/but-workspace/src/lib.rs Outdated Show resolved Hide resolved
crates/but-workspace/src/lib.rs Outdated Show resolved Hide resolved
@krlvi krlvi marked this pull request as ready for review January 22, 2025 18:38
@krlvi krlvi merged commit de86c4e into master Jan 22, 2025
23 checks passed
@krlvi krlvi deleted the kv-branch-4 branch January 22, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron left review comments

Assignees
No one assigned
Labels
rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlvi @Byron