-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update-storybook-component #5792
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7e00a84
to
93e1cd9
Compare
93e1cd9
to
5cb3ad3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in general this LGTM, however now that these are all using the SFC syntax, we unfortunately don't get the default tests anymore. When running vite test
in packages/ui
it would previously include all the stories and at least make sure the components rendered. Appanrelyt the SFC syntax + vite-experimental-test-addon
aren't compatible yet. It's being tracked here: storybookjs/addon-svelte-csf#213
But anyway, it should be coming soon and I dont think its that big a deal if they're off again for a short while.
Yes, we can probably handle this in the next iteration, since I also want to revisit some prop exports. |
Migrate from storybook stories with two files to the single file story approach.