Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-storybook-component #5792

Merged
merged 24 commits into from
Dec 9, 2024
Merged

update-storybook-component #5792

merged 24 commits into from
Dec 9, 2024

Conversation

PavelLaptev
Copy link
Contributor

Migrate from storybook stories with two files to the single file story approach.

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 5:36pm
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 5:36pm

@ndom91 ndom91 force-pushed the update-storybook-component branch from 93e1cd9 to 5cb3ad3 Compare December 9, 2024 17:34
Copy link
Contributor

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in general this LGTM, however now that these are all using the SFC syntax, we unfortunately don't get the default tests anymore. When running vite test in packages/ui it would previously include all the stories and at least make sure the components rendered. Appanrelyt the SFC syntax + vite-experimental-test-addon aren't compatible yet. It's being tracked here: storybookjs/addon-svelte-csf#213

But anyway, it should be coming soon and I dont think its that big a deal if they're off again for a short while. :shipit:

@PavelLaptev
Copy link
Contributor Author

But anyway, it should be coming soon and I dont think its that big a deal if they're off again for a short while. :shipit:

Yes, we can probably handle this in the next iteration, since I also want to revisit some prop exports.

@PavelLaptev PavelLaptev merged commit b0f7db7 into master Dec 9, 2024
17 checks passed
@PavelLaptev PavelLaptev deleted the update-storybook-component branch December 9, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants