fixes reflog timestamps #3901
Merged
fixes reflog timestamps #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Time stapms are super imporatant for this (thanks @schacon) - without a correct time stamp, the trees will be GC'd
|
That'a a great catch and sorry for not catching this myself! Over in my latest PR I have added a test for this and could verify that it indeed fails before this fix, but works after. |
Byron
reviewed
May 30, 2024
| @@ -86,7 +86,7 @@ fn standard_signature() -> gix::actor::SignatureRef<'static> { | |||
| gix::actor::SignatureRef { | |||
| name: GITBUTLER_INTEGRATION_COMMIT_AUTHOR_NAME.into(), | |||
| email: GITBUTLER_INTEGRATION_COMMIT_AUTHOR_EMAIL.into(), | |||
| time: Default::default(), | |||
| time: gix::date::Time::now_local_or_utc(), | |||
There was a problem hiding this comment.
It's good that we don't care, but as a word of warning, unless the application is single-threaded or sets time::set_soundness(Unsound), the timezone offset won't be available.
This is as time still relies on libc for this, and it isn't threadsafe. This will be an issue until this was implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time stapms are super imporatant for this (thanks @schacon) - without a correct time stamp, the trees will be GC'd