test: early return

apps/desktop/src/lib/dragging/dropzone.ts

@@ -146,16 +146,21 @@ export const dropzoneRegistry = new Map<HTMLElement, Dropzone>();
 
 export function dropzone(node: HTMLElement, configuration: DropzoneConfiguration) {
 	function setup(configuration: DropzoneConfiguration) {
+		console.log('registryNode', node);
 		if (configuration.disabled) return;
+		if (!node) return;
 
 		if (dropzoneRegistry.has(node)) {
+			console.log('registryNode.cleaning');
 			clean();
 		}
 
 		dropzoneRegistry.set(node, new Dropzone(configuration, node));
 	}
 
 	function clean() {
+		if (!node) return;
+
 		dropzoneRegistry.get(node)?.unregister();
 		dropzoneRegistry.delete(node);
 	}

apps/desktop/src/lib/dragging/stackingReorderDropzoneManager.ts

@@ -8,20 +8,37 @@ export class StackingReorderDropzone {
 		private branchController: BranchController,
 		private currentSeries: PatchSeries,
 		private series: PatchSeries[],
-		private commitId: string
+		public commitId: string
 	) {}
 
 	accepts(data: any) {
 		if (!(data instanceof DraggableCommit)) return false;
 		if (data.branchId !== this.branchId) return false;
-		if (distanceBetweenCommits(this.series, data.commit.id, this.commitId) === 0) return false;
+		if (
+			this.commitId !== 'top' &&
+			distanceBetweenCommits(this.series, data.commit.id, this.commitId) === 0
+		)
+			return false;
 
 		return true;
 	}
 
 	onDrop(data: any) {
+		const allSeriesCommits = this.series.map((s) => ({
+			name: s.name,
+			commitIds: s.patches.map((p) => p.id)
+		}));
+
+		const flatCommits = allSeriesCommits.flatMap((s) => s.commitIds);
+
+		console.log('onDrop', {
+			data,
+			find: flatCommits.find((p) => p === data.commit.id)
+		});
+
 		if (!(data instanceof DraggableCommit)) return;
 		if (data.branchId !== this.branchId) return;
+		if (!flatCommits.find((p) => p === data.commit.id)) return;
 
 		const stackOrder = getTargetStackOrder(
 			this.series,
@@ -30,7 +47,7 @@ export class StackingReorderDropzone {
 			this.commitId
 		);
 
-		// console.log('onDrop.stackOrder.series', { series: stackOrder });
+		console.log('onDrop.stackOrder.series', { series: stackOrder });
 		if (stackOrder) {
 			this.branchController.reorderStackCommit(data.branchId, stackOrder);
 		}