Fixed zombie objects creation in Batch API #91
Conversation
Was: 1. "upload" response for the first attempt to "download" non-existing object. 2. "download" + "upload" response for any consecutive attempt to "download" non-existing object.
| @@ -323,9 +323,21 @@ func (a *App) BatchHandler(w http.ResponseWriter, r *http.Request) { | |||
| } | |||
|
|
|||
| // Object is not found | |||
| meta, err = a.metaStore.Put(object) | |||
| if err == nil { | |||
| responseObjects = append(responseObjects, a.Represent(object, meta, meta.Existing, true, useTus)) | |||
There was a problem hiding this comment.
To annotate this for future readers, what's going on here is that if the object is not found, we currently store a stub entry and return an upload response. However, if we're attempting to download, there's no reason to create a stub, since the user didn't request that, and so we should produce a 404 response for this object instead.
Because the Put method returns meta.Existing set to true here, we produce both a download and an upload.
| if bv.Operation == "upload" { | ||
| meta, err = a.metaStore.Put(object) | ||
| if err == nil { | ||
| responseObjects = append(responseObjects, a.Represent(object, meta, false, true, useTus)) |
There was a problem hiding this comment.
And here, we don't use meta.Existing because we know that either (a) the database entry did not previously exist or (b) it did, but the file didn't exist on disk and all we had was a stub in the database. In neither case is the entry valid for download, since there's no data to back it.
Was:
how-to-reproduce.txt