Fix EndpointRouting Guid regex + tests

[64J0]

Description

With this PR, I'm fixing the EndpointRouting Guid regex (route constraint) and adding more automated tests to assert that it's working.

How to test

You can use this project example:

open System
open Microsoft.AspNetCore.Builder
open Microsoft.Extensions.DependencyInjection
open Microsoft.Extensions.Hosting
open Giraffe
open Giraffe.EndpointRouting

let endpoints =
    [ GET
          [ route "/" (text "Hello World")
            routef "/try-a-guid/%O" (fun (guid: Guid) -> text $"Success: {guid}") ] ]

let notFoundHandler = "Not Found" |> text |> RequestErrors.notFound

let configureApp (appBuilder: IApplicationBuilder) =
    appBuilder.UseRouting().UseGiraffe(endpoints).UseGiraffe(notFoundHandler)

let configureServices (services: IServiceCollection) =
    services.AddRouting().AddGiraffe() |> ignore

[<EntryPoint>]
let main args =
    let builder = WebApplication.CreateBuilder(args)
    configureServices builder.Services

    let app = builder.Build()

    configureApp app
    app.Run()

    0

And test with some inputs. For example:

# must not find
curl http://localhost:5000/try-a-guid/8b3557db-fa-c0c90785ec0b

# must work fine
curl http://localhost:5000/try-a-guid/8b3557db-fa-c0c90785ec
# ...

You can find more Guid ideas at the automated tests file.

Related issues

• Close Guid pattern in endpoint router matches invalid values, throws System.FormatException #576

[dbrattli]

The last part |^[-_0-9A-Za-z]{{22}}$ matches for a 22 char GUID e.g 0000000000000000000000 but there´s no test for it. Is there a format for such a GUID?

[64J0]

It's this ShortGuid format. I'll add a test for it.

[64J0]

Done with this commit b57fac8

[dbrattli]

LGTM!

[nojaf]

Great job!